From patchwork Tue Oct 13 11:37:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 529693 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3D309140187 for ; Tue, 13 Oct 2015 22:37:25 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752482AbbJMLhT (ORCPT ); Tue, 13 Oct 2015 07:37:19 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:61502 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751733AbbJMLhR (ORCPT ); Tue, 13 Oct 2015 07:37:17 -0400 Received: from wuerfel.localnet ([149.172.15.242]) by mrelayeu.kundenserver.de (mreue101) with ESMTPSA (Nemesis) id 0LxfEh-1afYa418ep-017Adg; Tue, 13 Oct 2015 13:37:11 +0200 From: Arnd Bergmann To: Jeff Kirsher Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Jesse Brandeburg , kbuild-all@01.org, Andrew Bowers , Shannon Nelson , Carolyn Wyborny , Don Skidmore , Matthew Vick , John Ronciak , Mitch Williams , David Miller Subject: Re: [PATCH] i40evf: fix 32 bit build warnings Date: Tue, 13 Oct 2015 13:37:04 +0200 Message-ID: <57023416.17EujnXPCo@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1444717101.2870.16.camel@intel.com> References: <6607276.TY67sbLLqL@wuerfel> <1444717101.2870.16.camel@intel.com> MIME-Version: 1.0 X-Provags-ID: V03:K0:wRa0eW8jUsTBI5R+NF1mQnb9O/CXK9HG6xrd4aT2AqKSWnaaGIM S+3SWznsnxZdaS0Urv1M5kEbOt3A27mMwcpfi1Nje5yW/FFlucAuRNk6SuT7IJxUabs2s02 KHW0K/xfl9ncSXJCfC6FksswPGeVsPHa0jyi3vq6zVv9dh5l39tSU7VzPdrFk7GUGaPljPW U5muSK8SigSOJ/cZTXEZg== X-UI-Out-Filterresults: notjunk:1; V01:K0:jWMPvy3mu40=:P0NSFVPD1Krrj5+InxR/Cy PevJctasczPZqsyObfF2S+vZDIgIjuVr78xzPr5iDKfZu3wAaw4Y92MRLOq5KOSTSnXmLDe/N Lu3dQsXFlCt4/RBUlgDoMxHnDkSnymIMjqmMbdDhZgJFRkRoGX2xQP47B2DIdj1tlPMSVm8pj z2hOF32OY5EcBvsyF8lIYlhxFSSHvulq9eqM2vSAuYNj8J/nveb68CTEOcvLCs4a47aXTY9I3 PlI81H2Xy8IC4WFXd6ENBBPaN1Dl85MgwsX2n8vjPXUGHBSC+7+gTq3OeDcQwO5/9snAP5y/m jEC/k8V9q0euYNDC1TMhNLjW1JRsCKgjUTV5ifqWdQVWHb5Z9FlUWE4Tq6jg1ZD0lXktPli1U EIWnRg0/3Xv0W4DtNSvsOk0A57RiNZv+xASbFowTs4BATKL4sz9zbMHiDd8v5w9Zyiq6K/pef KYqntmARD6fCFxgEPyjSmPH9UcnZThbvyRhr0D1BJ6muldrYdFKZ7Dm8q+UvCY+bRZ9v5/EFt e4v8FmKwe+jECJgOPkeq1X5MVa5MPPzl2XaDT6tal9kVZNCZ/fNXwcy1A+XX3pAL+ndmhiucL r79eI05nJQTInPre+CvKgeL7rwHidx+08h3RuA7T5d1YPRzWEy2nO3ULlve319jVFJU4h0P0V MtnvbPJVXNKP2KGi3pvhiDc+6NxTSk2n8ehypIzTOgIUf6Qf7EiR7yZPxe599Squ+XiEeXZdm reruTokIdlrYDGIi Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Monday 12 October 2015 23:18:21 you wrote: > On Wed, 2015-10-07 at 22:13 +0200, Arnd Bergmann wrote: > > Jesse Brandeburg fixed a bug for 32-bit systems in the i40e driver > > in commit 9c70d7cebfec5 ("i40e: fix 32 bit build warnings"), but the > > same code still exists in the i40evf driver and causes compilation > > warnings in ARM and x86 allmodconfig: > > > > drivers/net/ethernet/intel/i40evf/i40e_common.c:445:68: warning: cast > > from pointer to integer of different size [-Wpointer-to-int-cast] > > drivers/net/ethernet/intel/i40evf/i40e_common.c:446:71: warning: cast > > from pointer to integer of different size [-Wpointer-to-int-cast] > > > > This applies the same fix by removing the broken code. > > > > Signed-off-by: Arnd Bergmann > > Does not apply at all to my next-queue tree (dev-queue branch), my > guess is that this is already fixed in one of the patches already in my > queue. > I still get these warnings on your branch: /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c: In function 'i40e_aq_get_set_rss_lut': /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:446:68: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:446:128: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:446:207: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:446:285: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:446:363: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:446:444: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:447:71: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:447:115: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:447:178: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:447:240: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:447:302: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:447:367: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c: In function 'i40e_aq_get_set_rss_key': /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:523:68: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:523:128: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:523:207: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:523:285: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:523:363: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:523:444: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:524:71: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:524:115: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:524:178: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:524:240: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:524:302: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] /git/arm-soc/drivers/net/ethernet/intel/i40evf/i40e_common.c:524:367: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] This is the majority of all build warnings we get on allmodconfig (both i386 and arm), so it would be really nice to have it fixed before 4.3. For all I can tell, the patch still applies on your branch too, but see below for the rebased version. I also note that your branch is not part of linux-next, is that intentional? Arnd 8<------- From e6245d40a1ad7faa9064c23aa3d737d67d628683 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Wed, 7 Oct 2015 21:56:09 +0200 Subject: [PATCH] i40evf: fix 32 bit build warnings Jesse Brandeburg fixed a bug for 32-bit systems in the i40e driver in commit 9c70d7cebfec5 ("i40e: fix 32 bit build warnings"), but the same code still exists in the i40evf driver and causes compilation warnings in ARM and x86 allmodconfig: drivers/net/ethernet/intel/i40evf/i40e_common.c:445:68: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/net/ethernet/intel/i40evf/i40e_common.c:446:71: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] This applies the same fix by removing the broken code. Cc: kbuild-all@01.org Cc: Jesse Brandeburg Cc: Andrew Bowers Cc: Jeff Kirsher Signed-off-by: Arnd Bergmann --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/intel/i40evf/i40e_common.c b/drivers/net/ethernet/intel/i40evf/i40e_common.c index b98b642b897a..a98a31f1e246 100644 --- a/drivers/net/ethernet/intel/i40evf/i40e_common.c +++ b/drivers/net/ethernet/intel/i40evf/i40e_common.c @@ -443,9 +443,6 @@ static i40e_status i40e_aq_get_set_rss_lut(struct i40e_hw *hw, I40E_AQC_SET_RSS_LUT_TABLE_TYPE_SHIFT) & I40E_AQC_SET_RSS_LUT_TABLE_TYPE_MASK)); - cmd_resp->addr_high = cpu_to_le32(high_16_bits((u64)lut)); - cmd_resp->addr_low = cpu_to_le32(lower_32_bits((u64)lut)); - status = i40evf_asq_send_command(hw, &desc, lut, lut_size, NULL); return status; @@ -520,8 +517,6 @@ static i40e_status i40e_aq_get_set_rss_key(struct i40e_hw *hw, I40E_AQC_SET_RSS_KEY_VSI_ID_SHIFT) & I40E_AQC_SET_RSS_KEY_VSI_ID_MASK)); cmd_resp->vsi_id |= cpu_to_le16((u16)I40E_AQC_SET_RSS_KEY_VSI_VALID); - cmd_resp->addr_high = cpu_to_le32(high_16_bits((u64)key)); - cmd_resp->addr_low = cpu_to_le32(lower_32_bits((u64)key)); status = i40evf_asq_send_command(hw, &desc, key, key_size, NULL);