From patchwork Tue Nov 10 15:51:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 542507 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5924E141419 for ; Wed, 11 Nov 2015 02:53:45 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=baylibre_com.20150623.gappssmtp.com header.i=@baylibre_com.20150623.gappssmtp.com header.b=G+Ehg8Rr; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754066AbbKJPxk (ORCPT ); Tue, 10 Nov 2015 10:53:40 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:36701 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753925AbbKJPv2 (ORCPT ); Tue, 10 Nov 2015 10:51:28 -0500 Received: by wmww144 with SMTP id w144so123575090wmw.1 for ; Tue, 10 Nov 2015 07:51:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre_com.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:organization:message-id:date:user-agent :mime-version:content-type:content-transfer-encoding; bh=SkqMH7tXOHbVtOBCVr8ckuqTFtmin/AEIs5doSpF6p0=; b=G+Ehg8Rr5WetLqA54hWAvKjOXgbDx7Q0622ukKX2JoPmc5g3jLSFNdIG7GmY1NNFRy sm8k2HWMqyLbsr1Ms/lgywOt1S0Px4UFSHSGZ9u/NIfmRrejqRHR1gMhbDMmme0pV4I8 VtNmBUoxMvWeGoen0cNuTkT9zo2JV2GjqEC532B8l8Gr0/svpU6S/eAWF6c16E/spNVB dp7LS9F1A7XBPMnzpyQ/fYuUQepWBDkLFTZnTHkuLVQXAwsgVK2ov8VS/HKaq4qfej/E HvXvPQE70kzrmBiYjCPAlCn4oZmFvm7wDrhTekMAaJnzOjFvrs+W8l8tMuPYNSJ86VQW WWOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:cc:organization:message-id:date :user-agent:mime-version:content-type:content-transfer-encoding; bh=SkqMH7tXOHbVtOBCVr8ckuqTFtmin/AEIs5doSpF6p0=; b=hWh2J6mTzHlcclZkbSS6N7CVGCLthHSuT0pLksczMS/ZahG3mPxWILEmmKysrA/AMJ JJxg0huqLGu47ymijn49fdcA7YKmMK3wojrPchfCpbWxclyq+cNHzUl4xjpuNcBXWBsP aB1azDeG4psUEnLS+Egom5z1dj1Rwrdgy0x5azjIboV5TT51lt6zKaYtvdqw5L7DreWd Aw9PUeLdiWrfZNEW/9CRJ8TyyzRzuqmvywcu1vXQfeDsBvu5oSMKx92LQH+7qadAibwc EoifdDyMKWG08o9TCdpdfc5g2IY5YbsY2VDwXBj7QFxPNCtJ+Y+iVfSr99V2b7FRhb5n 4pIg== X-Gm-Message-State: ALoCoQmTEMeJ/3HHuk7p0ddUAEKGt0uXWao0NFyLGu3ZiehGkjiB+T4kLdeeTBMjv9NBaIkNCdVw X-Received: by 10.28.140.208 with SMTP id o199mr5858452wmd.58.1447170687147; Tue, 10 Nov 2015 07:51:27 -0800 (PST) Received: from [192.168.1.21] ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id t20sm20489015wme.0.2015.11.10.07.51.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 07:51:26 -0800 (PST) From: Neil Armstrong Subject: [PATCH v2 2/6] net: dsa: mv88e6060: use the correct InitReady bit To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Florian Fainelli , Andrew Lunn , Guenter Roeck , Neil Armstrong , Vivien Didelot Organization: Baylibre Message-ID: <56421277.1030601@baylibre.com> Date: Tue, 10 Nov 2015 16:51:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org According to the mv88e6060 datasheet, the InitReady bit position is 11 and the polarity is inverted. Use the bit correctly to detect the end of initialization. Acked-by: Andrew Lunn Signed-off-by: Neil Armstrong Acked-by: Vivien Didelot --- drivers/net/dsa/mv88e6060.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6060.c b/drivers/net/dsa/mv88e6060.c index 6885ef5..eff5e18 100644 --- a/drivers/net/dsa/mv88e6060.c +++ b/drivers/net/dsa/mv88e6060.c @@ -102,7 +102,7 @@ static int mv88e6060_switch_reset(struct dsa_switch *ds) timeout = jiffies + 1 * HZ; while (time_before(jiffies, timeout)) { ret = REG_READ(REG_GLOBAL, 0x00); - if ((ret & 0x8000) == 0x0000) + if (ret & 0x800) break; usleep_range(1000, 2000);