From patchwork Mon Nov 2 10:57:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 538964 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id ABCE414031C for ; Mon, 2 Nov 2015 21:58:46 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=baylibre_com.20150623.gappssmtp.com header.i=@baylibre_com.20150623.gappssmtp.com header.b=P5+xCYLV; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753651AbbKBK52 (ORCPT ); Mon, 2 Nov 2015 05:57:28 -0500 Received: from mail-wi0-f182.google.com ([209.85.212.182]:34332 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753624AbbKBK5X (ORCPT ); Mon, 2 Nov 2015 05:57:23 -0500 Received: by wikq8 with SMTP id q8so48699784wik.1 for ; Mon, 02 Nov 2015 02:57:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre_com.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:organization:message-id:date:user-agent :mime-version:content-type:content-transfer-encoding; bh=XwGgrXg7ibcaccnFd0BdVZ4e27J5jm/G2U3sKDaYP2E=; b=P5+xCYLV+iW0ocC9s91EUX/BRbRuu5J99ITflHenU47EVXX0HcKJHpC608dZ3B/Zdu lhg+KzZiK7aJs1/zAMHzmsmecSqatkACiH1sXJHU0N8nTeoqzQgHGSiCvGYVfQGUK13H mIPb4wKIQGciJhthRXfSI7+AWRjwysQNJStZjsB7ERwxRIQWUDEUs8r1LoUuLOp9p9/X coWIhvtLwEFNUk4NSEpWlV2M8m+wyghWjXuflFIGn58mWs9YlDj6h7x+1u6aJlDQ49iE Sbm/csWSohh+tgEhy9gkiqVzNbLzu2d+omTYzLEJIS2kRqBUiry/wWJp+MvR0uLM9/4c KacQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:cc:organization:message-id:date :user-agent:mime-version:content-type:content-transfer-encoding; bh=XwGgrXg7ibcaccnFd0BdVZ4e27J5jm/G2U3sKDaYP2E=; b=AHWtARkysFnpUbl3VTMvQQTTNERfASoYydLfYY0VO1gzt2llsd2MvW7kVCoOt2NQ+9 0U6RUOExHhRn3WkFWBdOaYCYHM2njzt48a2agWqVDg++ReRps2KKRf5SCuy/9RO39vYg 9x4h270qH4xWNEOIBN0XpV2eJu+IjXOMy/HAxv5WqhpLzwJER8lEccLBIv3FKhrNbhmx GnSf11jR8zXNKpa/xWIozCnqhHx7De+MQdGpsr3livkAN80S1gxApvvBnT43GPLb8b/B bDuql/bJ6Rzc2PwcD/lfBCwbuC0l24/2XkA5Pzdeino5dEtySpuKfwWBNm8lXBNAiezQ tYqA== X-Gm-Message-State: ALoCoQmI1ELBO0IAJcbj3xFg9MEA7DBAnNd2525y19QnkC/nu9mtS6iKjK7OqevSGEst3IR+dOBS X-Received: by 10.194.134.135 with SMTP id pk7mr25890892wjb.48.1446461842363; Mon, 02 Nov 2015 02:57:22 -0800 (PST) Received: from [192.168.2.52] (cag06-6-78-235-100-105.fbx.proxad.net. [78.235.100.105]) by smtp.gmail.com with ESMTPSA id h198sm17457965wmd.9.2015.11.02.02.57.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Nov 2015 02:57:21 -0800 (PST) From: Neil Armstrong Subject: [RFC PATCH net-next 2/6] net: dsa: mv88e6060: use the correct InitReady bit To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Florian Fainelli , Andrew Lunn , Guenter Roeck , Neil Armstrong , Vivien Didelot Organization: Baylibre Message-ID: <56374188.1010603@baylibre.com> Date: Mon, 2 Nov 2015 11:57:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org According to the mv88e6060 datasheet, the InitReady bit position is 11 and the polarity is inverted. Use the bit correctly to detect the end of initialization. Signed-off-by: Neil Armstrong --- drivers/net/dsa/mv88e6060.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6060.c b/drivers/net/dsa/mv88e6060.c index 6885ef5..c10880f 100644 --- a/drivers/net/dsa/mv88e6060.c +++ b/drivers/net/dsa/mv88e6060.c @@ -102,7 +102,7 @@ static int mv88e6060_switch_reset(struct dsa_switch *ds) timeout = jiffies + 1 * HZ; while (time_before(jiffies, timeout)) { ret = REG_READ(REG_GLOBAL, 0x00); - if ((ret & 0x8000) == 0x0000) + if ((ret & 0x800) != 0x0000) break; usleep_range(1000, 2000);