From patchwork Thu Dec 4 17:36:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Ruprecht X-Patchwork-Id: 417871 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 884071400E7 for ; Fri, 5 Dec 2014 04:43:42 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932776AbaLDRnZ (ORCPT ); Thu, 4 Dec 2014 12:43:25 -0500 Received: from eridanus.uberspace.de ([82.98.87.120]:52911 "EHLO eridanus.uberspace.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932738AbaLDRnX (ORCPT ); Thu, 4 Dec 2014 12:43:23 -0500 X-Greylist: delayed 399 seconds by postgrey-1.27 at vger.kernel.org; Thu, 04 Dec 2014 12:43:23 EST Received: (qmail 30233 invoked from network); 4 Dec 2014 17:36:40 -0000 Received: from localhost (HELO ?192.168.178.21?) (127.0.0.1) by eridanus.uberspace.de with SMTP; 4 Dec 2014 17:36:40 -0000 Message-ID: <54809BA5.7030901@rupran.de> Date: Thu, 04 Dec 2014 18:36:37 +0100 From: Andreas Ruprecht User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Jim Davis , Stephen Rothwell , linux-next , linux-kernel , jiri@resnulli.us, sfeldma@gmail.com, netdev Subject: [PATCH] net: ethernet: rocker: Add select to CONFIG_BRIDGE in Kconfig References: In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 04.12.2014 17:34, Jim Davis wrote: > Building with the attached random configuration file, > > drivers/built-in.o: In function `rocker_port_fdb_learn_work': > /home/jim/linux/drivers/net/ethernet/rocker/rocker.c:3014: undefined > reference to `br_fdb_external_learn_del' > /home/jim/linux/drivers/net/ethernet/rocker/rocker.c:3016: undefined > reference to `br_fdb_external_learn_add' > Hi, the problem here is that CONFIG_BRIDGE is set to 'm' (leading to inclusion of the two functions above in the kernel module) while CONFIG_ROCKER is set to 'y', requiring the functions at link time. Is the attached patch sufficient to fix this? Regards, Andreas Acked-by: Jiri Pirko From 0529c3cbe381338dc3337e07a71e15b3d22a3255 Mon Sep 17 00:00:00 2001 From: Andreas Ruprecht Date: Thu, 4 Dec 2014 18:28:09 +0100 Subject: [PATCH] net: ethernet: rocker: Add select to CONFIG_BRIDGE in Kconfig In a configuration with CONFIG_BRIDGE set to 'm' and CONFIG_ROCKER set to 'y', undefined references occur at link time: > drivers/built-in.o: In function `rocker_port_fdb_learn_work': > /home/jim/linux/drivers/net/ethernet/rocker/rocker.c:3014: undefined > reference to `br_fdb_external_learn_del' > /home/jim/linux/drivers/net/ethernet/rocker/rocker.c:3016: undefined > reference to `br_fdb_external_learn_add' This patch fixes these by selecting CONFIG_BRIDGE from CONFIG_ROCKER. Reported-by: Jim Davis Signed-off-by: Andreas Ruprecht --- drivers/net/ethernet/rocker/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/rocker/Kconfig b/drivers/net/ethernet/rocker/Kconfig index 11a850eab628..ade10ec4c78d 100644 --- a/drivers/net/ethernet/rocker/Kconfig +++ b/drivers/net/ethernet/rocker/Kconfig @@ -18,6 +18,7 @@ if NET_VENDOR_ROCKER config ROCKER tristate "Rocker switch driver (EXPERIMENTAL)" depends on PCI && NET_SWITCHDEV + select BRIDGE ---help--- This driver supports Rocker switch device. -- 1.9.1