From patchwork Thu Apr 3 15:45:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Holler X-Patchwork-Id: 336659 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C284F140093 for ; Fri, 4 Apr 2014 02:46:06 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752921AbaDCPpx (ORCPT ); Thu, 3 Apr 2014 11:45:53 -0400 Received: from h1446028.stratoserver.net ([85.214.92.142]:45841 "EHLO mail.ahsoftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752905AbaDCPpt (ORCPT ); Thu, 3 Apr 2014 11:45:49 -0400 Received: by mail.ahsoftware.de (Postfix, from userid 65534) id 09505423C2C9; Thu, 3 Apr 2014 17:45:47 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.ahsoftware.de X-Spam-Level: X-Spam-Status: No, score=-98.7 required=5.0 tests=RDNS_NONE, USER_IN_WHITELIST autolearn=disabled version=3.3.1 Received: from eiche.ahsoftware (p57B21E2D.dip0.t-ipconnect.de [87.178.30.45]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.ahsoftware.de (Postfix) with ESMTPSA id F0509423C2A9; Thu, 3 Apr 2014 17:45:46 +0200 (CEST) Received: by eiche.ahsoftware (Postfix, from userid 65534) id 385CA7F861; Thu, 3 Apr 2014 17:45:46 +0200 (CEST) Received: from krabat.ahsoftware (unknown [IPv6:feee::5246:5dff:fe8b:95f8]) by eiche.ahsoftware (Postfix) with ESMTP id 6485B80732; Thu, 3 Apr 2014 15:45:38 +0000 (UTC) Message-ID: <533D8221.7010103@ahsoftware.de> Date: Thu, 03 Apr 2014 17:45:37 +0200 From: Alexander Holler User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: David Miller CC: sebastian.hesselbarth@gmail.com, f.fainelli@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, michal.simek@xilinx.com, stable@vger.kernel.org Subject: Re: [PATCH regression] net: phy: fix initialization (config_init) for Marvel 88E1116R PHYs References: <533D0B09.9040602@ahsoftware.de> <533D207E.9020909@gmail.com> <533D790C.5000104@ahsoftware.de> <20140403.111401.1679730754008116799.davem@davemloft.net> In-Reply-To: <20140403.111401.1679730754008116799.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Am 03.04.2014 17:14, schrieb David Miller: > From: Alexander Holler > Date: Thu, 03 Apr 2014 17:06:52 +0200 > >> But don't suggest me (or insist on) a time consuming > > Bisects are not time consuming, and help developers analyze your > issue tremendously. Hmm, compiling and booting several dozen kernels isn't time consuming? Then I must have done something wrong in the past. And I wonder why I've writen descriptions at all, if nobody wants to understand that I already know the patch which leads to a broken network on that system. If the patch is really the reason for the problem, is something totally different, but bisecting won't help here. Besides that I know since 4 years that netconsole is broken on that box, it just never broke the network or anything else. And so I ignored it, foreseeing the necessary time to debug and especially describe and discuss the problem. You see, I'm already feeling like just talking with myself. But just in case: After reverting patch 7cd1463, there exist a online-change to turn on/off the problem: ------ ------ Thats basically just what the reverted patch does. Now, why should I still bisect? Of course, my first assumption that the changed reset is the bug is wrong, it just makes the problem to appear. But that wrong assumption still doesn't make a bisect necessary. And it's discouraging if people still insist on that. I will see if I spend the time to write down a more detailed description about what happens here. Regards, Alexander Holler --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index e891b48..246f065 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c @@ -2095,7 +2095,8 @@ static void port_start(struct mv643xx_eth_private *mp) struct ethtool_cmd cmd; mv643xx_eth_get_settings(mp->dev, &cmd); - phy_reset(mp); + //phy_reset(mp); + phy_init_hw(mp->phy); mv643xx_eth_set_settings(mp->dev, &cmd); phy_start(mp->phy); }