| Message ID | 521483CD.8050907@asianux.com |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
On 08/21/2013 11:09 AM, Chen Gang wrote: > 'priv->instance' may less than zero, so need a type cast, the related > warnings (allmodconfig, "EXTRA_CFLAGS=-W"): > > drivers/net/can/c_can/c_can_platform.c:198:3: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Tnx, I've tweaked the commit message a bit, will send a v2. Marc
On 08/21/2013 05:45 PM, Marc Kleine-Budde wrote: > On 08/21/2013 11:09 AM, Chen Gang wrote: >> 'priv->instance' may less than zero, so need a type cast, the related >> warnings (allmodconfig, "EXTRA_CFLAGS=-W"): >> >> drivers/net/can/c_can/c_can_platform.c:198:3: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] > > Tnx, I've tweaked the commit message a bit, will send a v2. > OK, thanks. > Marc >
diff --git a/drivers/net/can/c_can/c_can_platform.c b/drivers/net/can/c_can/c_can_platform.c index c6f838d..294ced3 100644 --- a/drivers/net/can/c_can/c_can_platform.c +++ b/drivers/net/can/c_can/c_can_platform.c @@ -195,7 +195,7 @@ static int c_can_plat_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 1); priv->raminit_ctrlreg = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(priv->raminit_ctrlreg) || priv->instance < 0) + if (IS_ERR(priv->raminit_ctrlreg) || (int)priv->instance < 0) dev_info(&pdev->dev, "control memory is not used for raminit\n"); else priv->raminit = c_can_hw_raminit;
'priv->instance' may less than zero, so need a type cast, the related warnings (allmodconfig, "EXTRA_CFLAGS=-W"): drivers/net/can/c_can/c_can_platform.c:198:3: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Signed-off-by: Chen Gang <gang.chen@asianux.com> --- drivers/net/can/c_can/c_can_platform.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)