| Message ID | 5097A030.5030209@asianux.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
于 2012年11月05日 19:17, Chen Gang 写道: > > the length of ifp->idev->dev->name is 16 (IFNAMSIZ) > in seq_printf, it is not suitable to use %8s for rt->dst.dev->name. > so change it to %s, since each line has not been solid any more. > 1) sorry, the comments is incorrect need use ifp->idev->dev->name instead of rt->dst.dev->name in 2nd line. I will send it again. 2) By the way, the three patches "* %8s to %s *" are almost the same If need merge them into one patch, please tell me, I shall do. thanks.
Chen Gang said, at 2012/11/6 9:11: > 1) sorry, the comments is incorrect > need use ifp->idev->dev->name instead of rt->dst.dev->name in 2nd line. > I will send it again. New patch, you should tag new version in [PATCH] to distinguish them. i.e. [PATCH V4] > > 2) By the way, the three patches "* %8s to %s *" are almost the same > If need merge them into one patch, please tell me, I shall do. trivial patches, send them in one patch for net/ subsystem. > > thanks. > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
于 2012年11月06日 09:42, Shan Wei 写道: > > New patch, you should tag new version in [PATCH] to distinguish them. > i.e. [PATCH V4] > thanks, I shall do it next time. > > trivial patches, send them in one patch for net/ subsystem. > 1) thanks, I shall do it next time. 2) if necessary A) need send one patch for the 3 patches, this time, B) please tell me clearly, C) I shall do, 3) By the way: A) for finding bugs, I truly find them one by one; B) When I find one and send it, not know also have another one. C) and now i) I will continue to search the 'same' issue, ii) if I am 'lucky' enough, iii) maybe also can find another (but maybe not net/ subsystem) welcome any members to giving suggestions and completions. thanks.
于 2012年11月06日 09:42, Shan Wei 写道: > > trivial patches, send them in one patch for net/ subsystem. > 1) Lucky ! A) this time, I truly find another one for "* %8s to %s". B) in arch/x86/kernel/process_64.c (task->comm, TASK_COMM_LEN is 16). C) It seems that it is not suitable to send it to net subsystem. 2) Next: A) I shall send it to relative members according to MAINTAINERS. 3) Suggestions: welcome any members to giving additional suggestions and completions. thanks.
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 8f0b12a..9f728a8 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -3281,7 +3281,7 @@ static void if6_seq_stop(struct seq_file *seq, void *v) static int if6_seq_show(struct seq_file *seq, void *v) { struct inet6_ifaddr *ifp = (struct inet6_ifaddr *)v; - seq_printf(seq, "%pi6 %02x %02x %02x %02x %8s\n", + seq_printf(seq, "%pi6 %02x %02x %02x %02x %s\n", &ifp->addr, ifp->idev->dev->ifindex,
the length of ifp->idev->dev->name is 16 (IFNAMSIZ) in seq_printf, it is not suitable to use %8s for rt->dst.dev->name. so change it to %s, since each line has not been solid any more. Signed-off-by: Chen Gang <gang.chen@asianux.com> --- net/ipv6/addrconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ifp->prefix_len,