| Message ID | 4b95a8c3d9a210c712f4366ea2d2f056cb302005.1561646575.git.aclaudi@redhat.com |
|---|---|
| State | Accepted |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | [iproute2] tc: netem: fix r parameter in Bernoulli loss model | expand |
diff --git a/tc/q_netem.c b/tc/q_netem.c index 6e0e8a8cbfde5..d1cd17f8a8a7e 100644 --- a/tc/q_netem.c +++ b/tc/q_netem.c @@ -284,14 +284,17 @@ static int netem_parse_opt(struct qdisc_util *qu, int argc, char **argv, } } else if (!strcmp(*argv, "gemodel")) { + double p; + NEXT_ARG(); - if (get_percent(&gemodel.p, *argv)) { + if (parse_percent(&p, *argv)) { explain1("loss gemodel p"); return -1; } + set_percent(&gemodel.p, p); /* set defaults */ - set_percent(&gemodel.r, 1.); + set_percent(&gemodel.r, 1. - p); set_percent(&gemodel.h, 0); set_percent(&gemodel.k1, 0); loss_type = NETEM_LOSS_GE;
As the man page for tc netem states: To use the Bernoulli model, the only needed parameter is p while the others will be set to the default values r=1-p, 1-h=1 and 1-k=0. However r parameter is erroneusly set to 1, and not to 1-p. Fix this using the same approach of the 4-state loss model. Fixes: 3c7950af598be ("netem: add support for 4 state and GE loss model") Signed-off-by: Andrea Claudi <aclaudi@redhat.com> --- tc/q_netem.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)