From patchwork Wed Dec 7 07:23:45 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Li X-Patchwork-Id: 129910 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C56D91007D2 for ; Wed, 7 Dec 2011 18:23:39 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752331Ab1LGHXe (ORCPT ); Wed, 7 Dec 2011 02:23:34 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:63022 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751799Ab1LGHXe (ORCPT ); Wed, 7 Dec 2011 02:23:34 -0500 Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3]) by song.cn.fujitsu.com (Postfix) with ESMTP id 5EE04170133; Wed, 7 Dec 2011 15:23:27 +0800 (CST) Received: from mailserver.fnst.cn.fujitsu.com (tang.cn.fujitsu.com [127.0.0.1]) by tang.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id pB77NQIp005834; Wed, 7 Dec 2011 15:23:26 +0800 Received: from [127.0.0.1] ([10.167.225.252]) by mailserver.fnst.cn.fujitsu.com (Lotus Domino Release 8.5.1FP4) with ESMTP id 2011120715225877-342239 ; Wed, 7 Dec 2011 15:22:58 +0800 Message-ID: <4EDF1481.1080106@cn.fujitsu.com> Date: Wed, 07 Dec 2011 15:23:45 +0800 From: Li Wei User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: netdev CC: "David S. Miller" , yoshfuji@linux-ipv6.org Subject: [PATCH] ipv6: Fix for adding multicast route for loopback device automatically. X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-12-07 15:22:58, Serialize by Router on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-12-07 15:22:59, Serialize complete at 2011-12-07 15:22:59 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There is no obvious reason to add a default multicast route for loopback devices, otherwise there would be a route entry whose dst.error set to -ENETUNREACH that would blocking all multicast packets. Signed-off-by: Li Wei --- net/ipv6/addrconf.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index cf88df8..36806de 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -1805,7 +1805,8 @@ static struct inet6_dev *addrconf_add_dev(struct net_device *dev) return ERR_PTR(-EACCES); /* Add default multicast route */ - addrconf_add_mroute(dev); + if (!(dev->flags & IFF_LOOPBACK)) + addrconf_add_mroute(dev); /* Add link local route */ addrconf_add_lroute(dev);