| Message ID | 4EB19BF9.8060801@parallels.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c index f06ee39..6be8d00 100644 --- a/net/bridge/br_input.c +++ b/net/bridge/br_input.c @@ -93,10 +93,11 @@ int br_handle_frame_finish(struct sk_buff *skb) skb2 = skb; br->dev->stats.multicast++; - } else if ((dst = __br_fdb_get(br, dest)) && dst->is_local) { + } else if ((dst = __br_fdb_get(br, dest)) != NULL) { skb2 = skb; /* Do not forward the packet since it's local. */ - skb = NULL; + if (dst->is_local) + skb = NULL; } if (skb) {
v2: extra bracket was removed if dst is not local br_handle_frame_finish() does not clone original skb and forgets to reset IPCB before return to IP stack. it can lead to stack corruption in icmp_send() Signed-off-by: Vasily Averin <vvs@sw.ru> --- net/bridge/br_input.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html