From patchwork Sun Mar 20 07:47:58 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philip Prindeville X-Patchwork-Id: 87650 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 499DFB6F2B for ; Sun, 20 Mar 2011 18:48:31 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751432Ab1CTHsP (ORCPT ); Sun, 20 Mar 2011 03:48:15 -0400 Received: from mail.redfish-solutions.com ([66.232.79.143]:58401 "EHLO mail.redfish-solutions.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750903Ab1CTHsN (ORCPT ); Sun, 20 Mar 2011 03:48:13 -0400 Received: from Philip-Prindevilles-MacBook-Pro.local (pool-71-111-114-150.ptldor.dsl-w.verizon.net [71.111.114.150]) (authenticated bits=0) by mail.redfish-solutions.com (8.14.4/8.14.4) with ESMTP id p2K7lx8l014158 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sun, 20 Mar 2011 01:48:05 -0600 Message-ID: <4D85B12E.5040005@redfish-solutions.com> Date: Sun, 20 Mar 2011 00:47:58 -0700 From: Philip Prindeville User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 MIME-Version: 1.0 To: Netdev CC: "linux-atm-general@lists.sourceforge.net" Subject: [PATCH 1/1] solos-pci: Fix debugging to include size, vpi/vci, but omit preamble X-Scanned-By: MIMEDefang 2.72 on 192.168.1.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Show the buffer length, vpi, and vci as we do on receive. Use the word "port" instead of "device" consistently. Don't display the "struct pkt_hdr" preamble on the sk_buff when doing hexdump of frame data. Signed-off-by: Philip Prindeville --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/atm/solos-pci.c.orig 2011-03-19 12:19:06.000000000 -0600 +++ b/drivers/atm/solos-pci.c 2011-03-19 12:45:18.000000000 -0600 @@ -697,7 +697,7 @@ void solos_bh(unsigned long card_arg) size); } if (atmdebug) { - dev_info(&card->dev->dev, "Received: device %d\n", port); + dev_info(&card->dev->dev, "Received: port %d\n", port); dev_info(&card->dev->dev, "size: %d VPI: %d VCI: %d\n", size, le16_to_cpu(header->vpi), le16_to_cpu(header->vci)); @@ -1025,8 +1025,15 @@ static uint32_t fpga_tx(struct solos_car /* Clean up and free oldskb now it's gone */ if (atmdebug) { + struct pkt_hdr *header = (void *)oldskb->data; + int size = le16_to_cpu(header->size); + + skb_pull(oldskb, sizeof(*header)); dev_info(&card->dev->dev, "Transmitted: port %d\n", port); + dev_info(&card->dev->dev, "size: %d VPI: %d VCI: %d\n", + size, le16_to_cpu(header->vpi), + le16_to_cpu(header->vci)); print_buffer(oldskb); }