| Message ID | 4CF34E03.8020504@cn.fujitsu.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Shan Wei <shanwei@cn.fujitsu.com> Date: Mon, 29 Nov 2010 14:53:55 +0800 > @@ -60,8 +60,7 @@ struct ipstats_mib { > }; > > /* ICMP */ > -#define ICMP_MIB_MAX (__ICMP_MIB_MAX + 1) > - > +#define ICMP_MIB_MAX __ICMP_MIB_MAX > struct icmp_mib { In all of my trees there is an "ICMP_MIB_DUMMY" define here, and it's been there forever, I have no idea what you are patching against. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: David Miller <davem@davemloft.net> Date: Wed, 01 Dec 2010 12:35:50 -0800 (PST) > From: Shan Wei <shanwei@cn.fujitsu.com> > Date: Mon, 29 Nov 2010 14:53:55 +0800 > >> @@ -60,8 +60,7 @@ struct ipstats_mib { >> }; >> >> /* ICMP */ >> -#define ICMP_MIB_MAX (__ICMP_MIB_MAX + 1) >> - >> +#define ICMP_MIB_MAX __ICMP_MIB_MAX >> struct icmp_mib { > > In all of my trees there is an "ICMP_MIB_DUMMY" define here, and it's > been there forever, I have no idea what you are patching against. Nevermind I see that this depends upon your first patch. Please resubmit all 3 patches once you've addressed the feedback for patch #1. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/net/snmp.h b/include/net/snmp.h index 835c587..762e2ab 100644 --- a/include/net/snmp.h +++ b/include/net/snmp.h @@ -60,8 +60,7 @@ struct ipstats_mib { }; /* ICMP */ -#define ICMP_MIB_MAX (__ICMP_MIB_MAX + 1) - +#define ICMP_MIB_MAX __ICMP_MIB_MAX struct icmp_mib { unsigned long mibs[ICMP_MIB_MAX]; };
__ICMP_MIB_MAX is equal to the total number of icmp mib, So no need to add 1. This wastes 4/8 bytes memory. Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com> --- include/net/snmp.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)