From patchwork Thu Oct 28 09:01:02 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Emelyanov X-Patchwork-Id: 69445 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 04755B70AA for ; Thu, 28 Oct 2010 20:01:15 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752383Ab0J1JBK (ORCPT ); Thu, 28 Oct 2010 05:01:10 -0400 Received: from mailhub.sw.ru ([195.214.232.25]:29794 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751871Ab0J1JBJ (ORCPT ); Thu, 28 Oct 2010 05:01:09 -0400 Received: from [10.30.3.76] ([10.30.3.76]) (authenticated bits=0) by relay.sw.ru (8.13.4/8.13.4) with ESMTP id o9S912e9026205 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 28 Oct 2010 13:01:03 +0400 (MSD) Message-ID: <4CC93BCE.4020303@parallels.com> Date: Thu, 28 Oct 2010 13:01:02 +0400 From: Pavel Emelyanov User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.11) Gecko/20100720 Fedora/3.0.6-1.fc12 Thunderbird/3.0.6 MIME-Version: 1.0 To: Paul Gortmaker CC: David Miller , Linux Netdev List Subject: [PATCH] 8390: Don't oops on starting dev queue Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The __NS8390_init tries to start the device queue before the device is registered. This results in an oops (snipped): [ 2.865493] BUG: unable to handle kernel NULL pointer dereference at 0000000000000010 [ 2.866106] IP: [] netif_start_queue+0xb/0x12 [8390] [ 2.881267] Call Trace: [ 2.881437] [] __NS8390_init+0x102/0x15a [8390] [ 2.881999] [] NS8390_init+0x9/0xb [8390] [ 2.882237] [] ne2k_pci_init_one+0x297/0x354 [ne2k_pci] [ 2.882955] [] local_pci_probe+0x12/0x16 [ 2.883308] [] pci_device_probe+0xc3/0xef [ 2.884049] [] driver_probe_device+0xbe/0x14b [ 2.884937] [] __driver_attach+0x46/0x62 [ 2.885170] [] bus_for_each_dev+0x49/0x78 [ 2.885781] [] driver_attach+0x1c/0x1e [ 2.886089] [] bus_add_driver+0xba/0x227 [ 2.886330] [] driver_register+0x9e/0x115 [ 2.886933] [] __pci_register_driver+0x50/0xac [ 2.887785] [] ne2k_pci_init+0x2c/0x2e [ne2k_pci] [ 2.888093] [] do_one_initcall+0x7c/0x130 [ 2.888693] [] sys_init_module+0x99/0x1da [ 2.888946] [] system_call_fastpath+0x16/0x1b This happens because the netif_start_queue sets respective bit on the dev->_tx array which is not yet allocated. As far as I understand the code removing the netif_start_queue from __NS8390_init is OK, since queue will be started later on device open. Plz, correct me if I'm wrong. Found in the Dave's current tree, so he's in Cc. Signed-off-by: Pavel Emelyanov --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/lib8390.c b/drivers/net/lib8390.c index 316bb70..e7030ce 100644 --- a/drivers/net/lib8390.c +++ b/drivers/net/lib8390.c @@ -1077,7 +1077,6 @@ static void __NS8390_init(struct net_device *dev, int startp) ei_outb_p(ei_local->rx_start_page, e8390_base + EN1_CURPAG); ei_outb_p(E8390_NODMA+E8390_PAGE0+E8390_STOP, e8390_base+E8390_CMD); - netif_start_queue(dev); ei_local->tx1 = ei_local->tx2 = 0; ei_local->txing = 0;