From patchwork Mon May 17 12:23:38 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shan Wei X-Patchwork-Id: 52789 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A208AB7D9A for ; Mon, 17 May 2010 22:24:45 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754692Ab0EQMYk (ORCPT ); Mon, 17 May 2010 08:24:40 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:52381 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752747Ab0EQMYj (ORCPT ); Mon, 17 May 2010 08:24:39 -0400 Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3]) by song.cn.fujitsu.com (Postfix) with ESMTP id 8B80A170135; Mon, 17 May 2010 20:24:36 +0800 (CST) Received: from fnst.cn.fujitsu.com (tang.cn.fujitsu.com [127.0.0.1]) by tang.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id o4HCMZkN031616; Mon, 17 May 2010 20:22:35 +0800 Received: from [10.167.141.214] (unknown [10.167.141.214]) by fnst.cn.fujitsu.com (Postfix) with ESMTPA id 13E5610C00A; Mon, 17 May 2010 20:28:08 +0800 (CST) Message-ID: <4BF1354A.3060003@cn.fujitsu.com> Date: Mon, 17 May 2010 20:23:38 +0800 From: Shan Wei User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: David Miller , Stephen Hemminger CC: "netdev@vger.kernel.org" Subject: [PATCH BUGFIX ] ipv6: fix the bug of address check Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org If there are several IPv6 addresses with same hash value in hashlist, and they are all not matched with addr argument. In this case, ipv6_chk_addr() should return 0. This bug is introduced by commit c2e21293c054817c42eb5fa9c613d2ad51954136 (title: ipv6: convert addrconf list to hlist). Signed-off-by: Shan Wei --- net/ipv6/addrconf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 3984f52..d8e5907 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -1291,7 +1291,7 @@ int ipv6_chk_addr(struct net *net, struct in6_addr *addr, } rcu_read_unlock_bh(); - return ifp != NULL; + return node != NULL; } EXPORT_SYMBOL(ipv6_chk_addr);