From patchwork Mon Mar 22 20:25:14 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: roel kluin X-Patchwork-Id: 48304 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 239F6B7CF9 for ; Tue, 23 Mar 2010 07:29:36 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756001Ab0CVU3I (ORCPT ); Mon, 22 Mar 2010 16:29:08 -0400 Received: from mail-ew0-f220.google.com ([209.85.219.220]:52589 "EHLO mail-ew0-f220.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754979Ab0CVU3G (ORCPT ); Mon, 22 Mar 2010 16:29:06 -0400 Received: by ewy20 with SMTP id 20so1642964ewy.1 for ; Mon, 22 Mar 2010 13:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=LH2JGM7XVVQYov6oLf+XQBuCJ81/mFSLIu4HaLt8LLY=; b=kzg+pF1CJPIqvPhCrLa9j4Clsm1PnQJTahdwLo7NEEUt1LYfWFn283S/YcDp+8LRC5 tzjaxl2c6z+4kE7NPw5b7514urKpuj8AIFcAswHfntnnn9m5X9n29ePUFZOfbxQnxUM8 XMxD5jw77psVW+B3fSewqMba4uEZvZchwP8WE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=roaSB7bIDzmeh6ZrTEOQK62l9hMUazOql6adWyXzT2Xe5tNfOG/nMbwH65DLI8H5Qw fnLFQeMVTb0qh+ativY7j5BjVIQM2Vf8p+RbolegS/WKSpCoj6q3N0LrtRXYT68KqeeT kOS0OLRh3WVbhrw02NSsYyDUjweW0amGuUiJE= Received: by 10.213.37.195 with SMTP id y3mr245977ebd.72.1269289379927; Mon, 22 Mar 2010 13:22:59 -0700 (PDT) Received: from zoinx.mars (d133062.upc-d.chello.nl [213.46.133.62]) by mx.google.com with ESMTPS id 14sm2295359ewy.2.2010.03.22.13.22.58 (version=SSLv3 cipher=RC4-MD5); Mon, 22 Mar 2010 13:22:58 -0700 (PDT) Message-ID: <4BA7D22A.6080300@gmail.com> Date: Mon, 22 Mar 2010 21:25:14 +0100 From: Roel Kluin User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Thunderbird/3.0.3 MIME-Version: 1.0 To: netdev@vger.kernel.org, Andrew Morton , LKML , Dave Jones , davem@davemloft.net Subject: [PATCH] via-velocity: FLOW_CNTL_RX does not disable Asymmetric pause in set_mii_flow_control() Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Asymmetric pause was not disabled in the RX case. Signed-off-by: Roel Kluin --- I spotted this because In the FLOW_CNTL_RX and FLOW_CNTL_TX_RX cases the same code is executed, is the amendment below required? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c index 3a486f3..2d478cf 100644 --- a/drivers/net/via-velocity.c +++ b/drivers/net/via-velocity.c @@ -807,7 +807,7 @@ static void set_mii_flow_control(struct velocity_info *vptr) case FLOW_CNTL_RX: MII_REG_BITS_ON(ANAR_PAUSE, MII_REG_ANAR, vptr->mac_regs); - MII_REG_BITS_ON(ANAR_ASMDIR, MII_REG_ANAR, vptr->mac_regs); + MII_REG_BITS_OFF(ANAR_ASMDIR, MII_REG_ANAR, vptr->mac_regs); break; case FLOW_CNTL_TX_RX: