| Message ID | 4A488021.50002@cn.fujitsu.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Wei Yongjun a écrit : > Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5) > broken the sctp protocol stack, the sctp packet can never be sent out after > Eric Dumazet's patch, which have typo in the sctp code. > > Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com> Oops, sorry ! Acked-by: Eric Dumazet <eric.dumazet@gmail.com> > --- > net/sctp/output.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/sctp/output.c b/net/sctp/output.c > index b764114..b94c211 100644 > --- a/net/sctp/output.c > +++ b/net/sctp/output.c > @@ -407,7 +407,7 @@ int sctp_packet_transmit(struct sctp_packet *packet) > } > dst = dst_clone(tp->dst); > skb_dst_set(nskb, dst); > - if (dst) > + if (!dst) > goto no_route; > > /* Build the SCTP header. */ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Wei Yongjun wrote: > Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5) > broken the sctp protocol stack, the sctp packet can never be sent out after > Eric Dumazet's patch, which have typo in the sctp code. > > Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com> Oh-oh!! Thanks for catching this. Acked-by: Vlad Yasevich <vladisalv.yasevich@hp.com> -vlad > --- > net/sctp/output.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/sctp/output.c b/net/sctp/output.c > index b764114..b94c211 100644 > --- a/net/sctp/output.c > +++ b/net/sctp/output.c > @@ -407,7 +407,7 @@ int sctp_packet_transmit(struct sctp_packet *packet) > } > dst = dst_clone(tp->dst); > skb_dst_set(nskb, dst); > - if (dst) > + if (!dst) > goto no_route; > > /* Build the SCTP header. */ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Vlad Yasevich <vladislav.yasevich@hp.com> Date: Mon, 29 Jun 2009 09:12:54 -0400 > Wei Yongjun wrote: >> Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5) >> broken the sctp protocol stack, the sctp packet can never be sent out after >> Eric Dumazet's patch, which have typo in the sctp code. >> >> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com> > > Oh-oh!! Thanks for catching this. > > Acked-by: Vlad Yasevich <vladisalv.yasevich@hp.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sctp/output.c b/net/sctp/output.c index b764114..b94c211 100644 --- a/net/sctp/output.c +++ b/net/sctp/output.c @@ -407,7 +407,7 @@ int sctp_packet_transmit(struct sctp_packet *packet) } dst = dst_clone(tp->dst); skb_dst_set(nskb, dst); - if (dst) + if (!dst) goto no_route; /* Build the SCTP header. */
Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5) broken the sctp protocol stack, the sctp packet can never be sent out after Eric Dumazet's patch, which have typo in the sctp code. Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com> --- net/sctp/output.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)