From patchwork Mon May 30 02:52:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kirtika Ruchandani X-Patchwork-Id: 627596 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rJ1PL1dpmz9t6N for ; Mon, 30 May 2016 12:52:22 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=ABB8rPNK; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753504AbcE3CwU (ORCPT ); Sun, 29 May 2016 22:52:20 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:36192 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753188AbcE3CwS (ORCPT ); Sun, 29 May 2016 22:52:18 -0400 Received: by mail-pa0-f68.google.com with SMTP id fg1so19884404pad.3; Sun, 29 May 2016 19:52:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4Kk4hqg1Uk3vS1mniwCHF+cE17q8yVTJtnhheTLYXf8=; b=ABB8rPNKnxmAncI6qRJNofeErFSdgiwa23FqkTSusDfqVWpeKr23+KUqMF9UiLKCy3 2k2KJjdJ76a35Gz++7BjRn66GTQu/25EL6Q9LRTxtPdORWpa2HaYSqlkXqkSXKJCbVm5 seNOWIwolg1vRrCJ8OId6/WBAEn3LKqm1hPbLMnYQpAJcNFo/iW1c0ZPNrxnz0R3pBnm UOwEC9JVPzsFWade6ulZfzBlC9fHTAxBqQXzup2qqbF00bkpI9dSmIKTseJweJXUA7fH fWweaYATzAezrVGV6sDvUTeICPtr5oPqRQOqMJtjHTurvEvuir9zny5BS0JlADpEyb2d khjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4Kk4hqg1Uk3vS1mniwCHF+cE17q8yVTJtnhheTLYXf8=; b=L9hZVzuGR4rU7k4KnoKyfJF+MmNu/65MSjbz2A0u+W/RsGViLT/WeL35d+73jsTeKZ WwH1T3UlDnEeV77Vk7ghAUHylPkl28IQIsqI3+y9XPkeFsugUDHCPrGafL/S9r3dP9gj 4FSW9vL/SWKQuVPgvJqCq0gEf5Op3k7BY3KrM2AXZqjcmVdmwX3DA5oCMTD3dxISoD+s S37jYqhMJ3FbcvRz23Y/aTAESz6KOwO9ZeAbdulW5niqrecuJ+vsAngzHS/p3yXddKh+ ppP/HWUz9iUqW4rlE6PkbNpWpwmuAYL2++9w5YfdNzgPp5Cbsdfw0ifT938rBk2tZzBq tjyg== X-Gm-Message-State: ALyK8tL1usgfepbdWMiXhInmue6dMqnSrUKgp7RAS0uC/lRXvXC8ZEH6rqOQUMh+RZFUQA== X-Received: by 10.66.25.236 with SMTP id f12mr42935452pag.35.1464576737639; Sun, 29 May 2016 19:52:17 -0700 (PDT) Received: from google.com ([2620:0:1000:1301:9988:7148:7bd6:87cc]) by smtp.gmail.com with ESMTPSA id p65sm28541377pfd.6.2016.05.29.19.52.16 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 29 May 2016 19:52:16 -0700 (PDT) Date: Sun, 29 May 2016 19:52:11 -0700 From: Kirtika Ruchandani To: Johannes Berg Cc: linux-wireless@vger.kernel.org, ruchandani.tina@gmail.com, netdev@vger.kernel.org, Julian.Calaby@gmail.com Subject: [PATCH v2 03/10] nl80211: Prefer ether_addr_copy Message-ID: <49c03996365360077fe7317d108072c30354b555.1464576022.git.kirtika.ruchandani@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes the checkpatch,pl to prefer ether_addr_copy over memcpy. Signed-off-by: Kirtika Ruchandani --- net/wireless/nl80211.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) -- 2.8.0.rc3.226.g39d4020 diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index cd422bd..34b8fbe 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -3194,7 +3194,7 @@ static struct cfg80211_acl_data *parse_acl_data(struct wiphy *wiphy, return ERR_PTR(-ENOMEM); nla_for_each_nested(attr, info->attrs[NL80211_ATTR_MAC_ADDRS], tmp) { - memcpy(acl->mac_addrs[i].addr, nla_data(attr), ETH_ALEN); + ether_addr_copy(acl->mac_addrs[i].addr, nla_data(attr)); i++; } @@ -5892,8 +5892,8 @@ static int nl80211_parse_random_mac(struct nlattr **attrs, if (!attrs[NL80211_ATTR_MAC] || !attrs[NL80211_ATTR_MAC_MASK]) return -EINVAL; - memcpy(mac_addr, nla_data(attrs[NL80211_ATTR_MAC]), ETH_ALEN); - memcpy(mac_addr_mask, nla_data(attrs[NL80211_ATTR_MAC_MASK]), ETH_ALEN); + ether_addr_copy(mac_addr, nla_data(attrs[NL80211_ATTR_MAC])); + ether_addr_copy(mac_addr_mask, nla_data(attrs[NL80211_ATTR_MAC_MASK])); /* don't allow or configure an mcast address */ if (!is_multicast_ether_addr(mac_addr_mask) || @@ -9405,8 +9405,7 @@ static int nl80211_parse_wowlan_tcp(struct cfg80211_registered_device *rdev, return -ENOMEM; cfg->src = nla_get_in_addr(tb[NL80211_WOWLAN_TCP_SRC_IPV4]); cfg->dst = nla_get_in_addr(tb[NL80211_WOWLAN_TCP_DST_IPV4]); - memcpy(cfg->dst_mac, nla_data(tb[NL80211_WOWLAN_TCP_DST_MAC]), - ETH_ALEN); + ether_addr_copy(cfg->dst_mac, nla_data(tb[NL80211_WOWLAN_TCP_DST_MAC])); if (tb[NL80211_WOWLAN_TCP_SRC_PORT]) port = nla_get_u16(tb[NL80211_WOWLAN_TCP_SRC_PORT]); else