diff mbox

sungem: another error printed one too early

Message ID 49A6914F.6070301@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

roel kluin Feb. 26, 2009, 12:55 p.m. UTC 
Roel Kluin wrote:
> Another error was printed one too early.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---

I am not sure why my script didn't report this earlier.
-----------------------------------------------------
Another error was printed one too early.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller March 4, 2009, 8:08 a.m. UTC | #1 
From: Roel Kluin <roel.kluin@gmail.com>
Date: Thu, 26 Feb 2009 13:55:43 +0100

> Another error was printed one too early.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/sungem.c b/drivers/net/sungem.c
index 8d64b1d..0fcb750 100644
--- a/drivers/net/sungem.c
+++ b/drivers/net/sungem.c
@@ -1229,7 +1229,7 @@  static void gem_reset(struct gem *gp)
 			break;
 	} while (val & (GREG_SWRST_TXRST | GREG_SWRST_RXRST));
 
-	if (limit <= 0)
+	if (limit < 0)
 		printk(KERN_ERR "%s: SW reset is ghetto.\n", gp->dev->name);
 
 	if (gp->phy_type == phy_serialink || gp->phy_type == phy_serdes)