From patchwork Wed Feb 18 09:19:50 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: roel kluin X-Patchwork-Id: 23333 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 80DFFDDDF3 for ; Wed, 18 Feb 2009 20:20:03 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752014AbZBRJT6 (ORCPT ); Wed, 18 Feb 2009 04:19:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753142AbZBRJT5 (ORCPT ); Wed, 18 Feb 2009 04:19:57 -0500 Received: from mail-ew0-f21.google.com ([209.85.219.21]:46320 "EHLO mail-ew0-f21.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753061AbZBRJTx (ORCPT ); Wed, 18 Feb 2009 04:19:53 -0500 Received: by ewy14 with SMTP id 14so2611066ewy.13 for ; Wed, 18 Feb 2009 01:19:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:content-type :content-transfer-encoding; bh=kuZycV6wWBPKi9CkWNBxb7698UjPIPavzozJRS3FVE0=; b=xojn+KoA+XndoogsdHYcwHrk9ESpZHYvm4n8dcRfB/G18kRZ2awUZGQJo+kyeG0iqA SeaSKYkCZTLptCYLd5RpXQDaNQFCuy4QooPOzCXrvgv0CKz1YBKQhYMnZK4QvvZtha+/ Dz2SY5WH6rWT/KYwfwKUtubXQzDZ2/omCR+lM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; b=CqcKIBzprvIe/AHd2L96HiCvw3DbYT4/9ifjnpCHVbHu71EO+7Txj4nGZ/ntdYBJC/ IuQ2UAVhhidl39Ibj5T9z5U9XnlRAdd83BxykHIYx/Xqeffhc3oetpETz4i0vHohmZg8 aKJIcldXmDWnNK0zGyrku1hkRZYxeFO67k60Y= Received: by 10.210.59.14 with SMTP id h14mr6094126eba.172.1234948791254; Wed, 18 Feb 2009 01:19:51 -0800 (PST) Received: from ?192.168.1.115? (d133062.upc-d.chello.nl [213.46.133.62]) by mx.google.com with ESMTPS id h1sm10619701nfh.56.2009.02.18.01.19.50 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 18 Feb 2009 01:19:50 -0800 (PST) Message-ID: <499BD2B6.1010407@gmail.com> Date: Wed, 18 Feb 2009 10:19:50 +0100 From: Roel Kluin User-Agent: Thunderbird 2.0.0.18 (X11/20081105) MIME-Version: 1.0 To: Jeff Garzik CC: netdev@vger.kernel.org, Andrew Morton Subject: [PATCH] sundance: missing parentheses? Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Please review. --------------------------->8-------------8<------------------------------ Add missing parentheses Signed-off-by: Roel Kluin --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/sundance.c b/drivers/net/sundance.c index feaf0e0..43695b7 100644 --- a/drivers/net/sundance.c +++ b/drivers/net/sundance.c @@ -909,7 +909,7 @@ static void check_duplex(struct net_device *dev) printk(KERN_INFO "%s: Setting %s-duplex based on MII #%d " "negotiated capability %4.4x.\n", dev->name, duplex ? "full" : "half", np->phys[0], negotiated); - iowrite16(ioread16(ioaddr + MACCtrl0) | duplex ? 0x20 : 0, ioaddr + MACCtrl0); + iowrite16(ioread16(ioaddr + MACCtrl0) | (duplex ? 0x20 : 0), ioaddr + MACCtrl0); } }