From patchwork Mon Feb 9 22:12:02 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: roel kluin X-Patchwork-Id: 22817 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 63B63DDDA1 for ; Tue, 10 Feb 2009 09:12:14 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753238AbZBIWMH (ORCPT ); Mon, 9 Feb 2009 17:12:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751623AbZBIWMH (ORCPT ); Mon, 9 Feb 2009 17:12:07 -0500 Received: from ug-out-1314.google.com ([66.249.92.173]:52308 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751357AbZBIWME (ORCPT ); Mon, 9 Feb 2009 17:12:04 -0500 Received: by ug-out-1314.google.com with SMTP id 39so126487ugf.37 for ; Mon, 09 Feb 2009 14:12:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:content-type :content-transfer-encoding; bh=K8bwtSu9l/cNgrS0H+CBU96AH9OupS4JjdXvaLwytDA=; b=KtX2mAxbcrbcmOp0MEHKRFTQrRALBPeCRAoASHiSCcyYOcG5CaGJZOVPBrfv+b1jCQ JOG9oo1heVlqbAFzFAL9J1aSQtXF+Snt06H6hSnb6TE+aun9OjNt5INcIXeRDlmQ/XLJ GxeiJkSBLbeSDzhF3NrCA0dDjtC6Lk/E9fsDU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; b=Yt4NJkFSgabRYWw2Jz8/BpPnuTAbgfXIuJ3l/O/uHnI2MPW8h/sG15wf8TcKOnMEpv FcYUtc4LbZy1ncm+hlmQg/LDWAjL5QtbCxCkDgXhq2aqOqniI29nvFaFdnFCssJVAA3A 8H02wrcX9v/Oj3NGXEOFj47geOCmArP6P0wNQ= Received: by 10.67.121.14 with SMTP id y14mr2812847ugm.72.1234217521673; Mon, 09 Feb 2009 14:12:01 -0800 (PST) Received: from ?192.168.1.115? (d133062.upc-d.chello.nl [213.46.133.62]) by mx.google.com with ESMTPS id 24sm12314413ugf.36.2009.02.09.14.12.00 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 09 Feb 2009 14:12:01 -0800 (PST) Message-ID: <4990AA32.1010004@gmail.com> Date: Mon, 09 Feb 2009 23:12:02 +0100 From: Roel Kluin User-Agent: Thunderbird 2.0.0.18 (X11/20081105) MIME-Version: 1.0 To: "David S. Miller" , netdev@vger.kernel.org CC: lkml Subject: [PATCH] cassini: i reaches 0, not -1. Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org With while (i-- > 0) { ... } i reaches 0, not -1. Signed-off-by: Roel Kluin --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/cassini.c b/drivers/net/cassini.c index bbbc3bb..2de2cdf 100644 --- a/drivers/net/cassini.c +++ b/drivers/net/cassini.c @@ -3568,7 +3568,7 @@ static inline void cas_start_dma(struct cas *cp) break; udelay(10); } - if (i < 0) txfailed = 1; + if (i <= 0) txfailed = 1; i = STOP_TRIES; while (i-- > 0) { val = readl(cp->regs + REG_MAC_RX_CFG);