| Message ID | 49870A39.8000806@option.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Filip Aben <f.aben@option.com> Date: Mon, 02 Feb 2009 15:59:05 +0100 > This patch adds a few device id's and removes one which will never be used. > > Signed-off-by: Filip Aben <f.aben@option.com> Why won't 0xaf0/0xd051 ever be used? You should explain such things in your commit message, that way I don't have to ask. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: maandag 2 februari 2009 23:03 > To: Filip Aben > Cc: gregkh@suse.de; netdev@vger.kernel.org; linux-usb@vger.kernel.org > Subject: Re: [PATCH] hso: add new device id's > > From: Filip Aben <f.aben@option.com> > Date: Mon, 02 Feb 2009 15:59:05 +0100 > > > This patch adds a few device id's and removes one which will never be > used. > > > > Signed-off-by: Filip Aben <f.aben@option.com> > > Why won't 0xaf0/0xd051 ever be used? > > You should explain such things in your commit message, > that way I don't have to ask. That ID was used in an internal engineering version of a device and will never see commercial light. Even if this ID will be 'recycled' in the future, which is very unlikely, I don't know what kind of device will be behind it. Therefore it's safer to remove it. Regards, Filip- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: "Filip Aben" <F.Aben@option.com> Date: Tue, 3 Feb 2009 01:26:14 +0100 > > -----Original Message----- > > From: David Miller [mailto:davem@davemloft.net] > > Sent: maandag 2 februari 2009 23:03 > > To: Filip Aben > > Cc: gregkh@suse.de; netdev@vger.kernel.org; linux-usb@vger.kernel.org > > Subject: Re: [PATCH] hso: add new device id's > > > > Why won't 0xaf0/0xd051 ever be used? > > > > You should explain such things in your commit message, > > that way I don't have to ask. > > That ID was used in an internal engineering version of a device and > will never see commercial light. > Even if this ID will be 'recycled' in the future, which is very > unlikely, > I don't know what kind of device will be behind it. Therefore it's safer > to remove it. Great, please add that information to the commit message and resend your patch. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
This patch adds a few device id's and removes one which will never be used. Signed-off-by: Filip Aben <f.aben@option.com> --- diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 0d0fa91..fe98aca 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c @@ -455,6 +455,7 @@ static const struct usb_device_id hso_ids[] = { {icon321_port_device(0x0af0, 0xd033)}, /* Icon-322 */ {USB_DEVICE(0x0af0, 0x7301)}, /* GE40x */ {USB_DEVICE(0x0af0, 0x7361)}, /* GE40x */ + {USB_DEVICE(0x0af0, 0x7381)}, /* GE40x */ {USB_DEVICE(0x0af0, 0x7401)}, /* GI 0401 */ {USB_DEVICE(0x0af0, 0x7501)}, /* GTM 382 */ {USB_DEVICE(0x0af0, 0x7601)}, /* GE40x */ @@ -462,7 +463,8 @@ static const struct usb_device_id hso_ids[] = { {USB_DEVICE(0x0af0, 0x7801)}, {USB_DEVICE(0x0af0, 0x7901)}, {USB_DEVICE(0x0af0, 0x7361)}, - {icon321_port_device(0x0af0, 0xd051)}, + {USB_DEVICE(0x0af0, 0xd057)}, + {USB_DEVICE(0x0af0, 0xd055)}, {} }; MODULE_DEVICE_TABLE(usb, hso_ids);
This patch adds a few device id's and removes one which will never be used. Signed-off-by: Filip Aben <f.aben@option.com> ---