From patchwork Mon Dec 8 05:33:22 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Chen X-Patchwork-Id: 12679 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 80F17DDEE9 for ; Mon, 8 Dec 2008 16:44:18 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751473AbYLHFoJ (ORCPT ); Mon, 8 Dec 2008 00:44:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751248AbYLHFoC (ORCPT ); Mon, 8 Dec 2008 00:44:02 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:52835 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751181AbYLHFoA (ORCPT ); Mon, 8 Dec 2008 00:44:00 -0500 Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3]) by song.cn.fujitsu.com (Postfix) with ESMTP id CAEE9170091; Mon, 8 Dec 2008 13:48:21 +0800 (CST) Received: from fnst.cn.fujitsu.com (localhost.localdomain [127.0.0.1]) by tang.cn.fujitsu.com (8.13.1/8.13.1) with ESMTP id mB85mJ5T013241; Mon, 8 Dec 2008 13:48:21 +0800 Received: from [127.0.0.1] (unknown [10.167.141.111]) by fnst.cn.fujitsu.com (Postfix) with ESMTPA id B5BB2293F3A; Mon, 8 Dec 2008 13:37:28 +0800 (CST) Message-ID: <493CB1A2.7080005@cn.fujitsu.com> Date: Mon, 08 Dec 2008 13:33:22 +0800 From: Wang Chen User-Agent: Thunderbird 2.0.0.18 (Windows/20081105) MIME-Version: 1.0 To: "David S. Miller" CC: gregkh@suse.de, NETDEV Subject: [PATCH next] staging-winbond: Kill directly reference of netdev->priv Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This driver is not yet finished. At this time, we don't know how netdev be created and how private data be allocated. So, simply use netdev_priv() now and leave some temp comment. Compile test only. Signed-off-by: Wang Chen --- drivers/staging/winbond/linux/wbusb.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/staging/winbond/linux/wbusb.c b/drivers/staging/winbond/linux/wbusb.c index f4a7875..39ca9b9 100644 --- a/drivers/staging/winbond/linux/wbusb.c +++ b/drivers/staging/winbond/linux/wbusb.c @@ -336,7 +336,11 @@ WbUsb_destroy(phw_data_t pHwData) int wb35_open(struct net_device *netdev) { - PADAPTER Adapter = (PADAPTER)netdev->priv; + /* netdev_priv() or netdev->ml_priv should reference to the address of + * private data(PADAPTER). It depends on whether private data memory is + * allocated when alloc_netdev(). + */ + PADAPTER Adapter = (PADAPTER)netdev_priv(netdev); phw_data_t pHwData = &Adapter->sHwData; netif_start_queue(netdev);