From patchwork Mon Jul 13 22:37:13 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tilman Schmidt X-Patchwork-Id: 494821 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 76F2E14076B for ; Tue, 14 Jul 2015 09:32:31 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752560AbbGMXbi (ORCPT ); Mon, 13 Jul 2015 19:31:38 -0400 Received: from mail.pxnet.com ([89.1.7.7]:55415 "EHLO mail.pxnet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751630AbbGMXbh (ORCPT ); Mon, 13 Jul 2015 19:31:37 -0400 X-Greylist: delayed 3252 seconds by postgrey-1.27 at vger.kernel.org; Mon, 13 Jul 2015 19:31:36 EDT Received: from krypton.ts.pxnet.com (p20030070CF5D8D008E705AFFFE372C72.dip0.t-ipconnect.de [IPv6:2003:70:cf5d:8d00:8e70:5aff:fe37:2c72]) (user=ts author=<> mech=DIGEST-MD5 bits=0) by mail.pxnet.com (8.13.8/8.13.8) with ESMTP id t6DMbDJQ000322; Tue, 14 Jul 2015 00:37:17 +0200 Received: by krypton.ts.pxnet.com (Postfix, from userid 500) id 407942A02D9; Tue, 14 Jul 2015 00:37:13 +0200 (CEST) Message-Id: <40ceea060d328b84da061f115e7ed9b99d28cf74.1436826434.git.tilman@imap.cc> In-Reply-To: References: From: Tilman Schmidt Subject: [PATCH 2/2] isdn/gigaset: drop unused ldisc methods To: Paul Bolle Cc: netdev@vger.kernel.org, David Miller , Hansjoerg Lipp , linux-kernel@vger.kernel.org Date: Tue, 14 Jul 2015 00:37:13 +0200 (CEST) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.pxnet.com [IPv6:2001:4dd0:f004:7::7]); Tue, 14 Jul 2015 00:37:18 +0200 (CEST) X-Scanned-By: MIMEDefang 2.70 on IPv6:2001:4dd0:f004:7::7 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The line discipline read and write methods are optional so the dummy methods in ser_gigaset are unnecessary and can be removed. Signed-off-by: Tilman Schmidt --- drivers/isdn/gigaset/ser-gigaset.c | 24 ------------------------ 1 files changed, 0 insertions(+), 24 deletions(-) diff --git a/drivers/isdn/gigaset/ser-gigaset.c b/drivers/isdn/gigaset/ser-gigaset.c index 3ac9c41..375be50 100644 --- a/drivers/isdn/gigaset/ser-gigaset.c +++ b/drivers/isdn/gigaset/ser-gigaset.c @@ -607,28 +607,6 @@ static int gigaset_tty_hangup(struct tty_struct *tty) } /* - * Read on the tty. - * Unused, received data goes only to the Gigaset driver. - */ -static ssize_t -gigaset_tty_read(struct tty_struct *tty, struct file *file, - unsigned char __user *buf, size_t count) -{ - return -EAGAIN; -} - -/* - * Write on the tty. - * Unused, transmit data comes only from the Gigaset driver. - */ -static ssize_t -gigaset_tty_write(struct tty_struct *tty, struct file *file, - const unsigned char *buf, size_t count) -{ - return -EAGAIN; -} - -/* * Ioctl on the tty. * Called in process context only. * May be re-entered by multiple ioctl calling threads. @@ -761,8 +739,6 @@ static struct tty_ldisc_ops gigaset_ldisc = { .open = gigaset_tty_open, .close = gigaset_tty_close, .hangup = gigaset_tty_hangup, - .read = gigaset_tty_read, - .write = gigaset_tty_write, .ioctl = gigaset_tty_ioctl, .receive_buf = gigaset_tty_receive, .write_wakeup = gigaset_tty_wakeup,