From patchwork Sun Nov 21 02:38:38 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Perches X-Patchwork-Id: 72394 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D1BBBB716A for ; Sun, 21 Nov 2010 13:47:27 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756833Ab0KUCkU (ORCPT ); Sat, 20 Nov 2010 21:40:20 -0500 Received: from mail.perches.com ([173.55.12.10]:1695 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756121Ab0KUCkS (ORCPT ); Sat, 20 Nov 2010 21:40:18 -0500 Received: from Joe-Laptop.home (unknown [192.168.1.156]) by mail.perches.com (Postfix) with ESMTP id 375B12436E; Sat, 20 Nov 2010 18:40:11 -0800 (PST) From: Joe Perches To: Francois Romieu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 37/62] r8169: Use static const Date: Sat, 20 Nov 2010 18:38:38 -0800 Message-Id: <400a1fb40ac73a27cd214d535d312c372e961643.1290305776.git.joe@perches.com> X-Mailer: git-send-email 1.7.3.2.245.g03276.dirty In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Using static const generally increases object text and decreases data size. It also generally decreases overall object size. text data bss dec hex filename 43939 232 9904 54075 d33b drivers/net/r8169.o.new 43974 232 9904 54110 d35e drivers/net/r8169.o.old Signed-off-by: Joe Perches --- drivers/net/r8169.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 7d33ef4..f9ad0d6 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -2516,7 +2516,7 @@ static void rtl8168d_2_hw_phy_config(void __iomem *ioaddr) val = mdio_read(ioaddr, 0x0d); if ((val & 0x00ff) != 0x006c) { - u32 set[] = { + static const u32 set[] = { 0x0065, 0x0066, 0x0067, 0x0068, 0x0069, 0x006a, 0x006b, 0x006c };