From patchwork Sun Mar 14 22:58:05 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tilman Schmidt X-Patchwork-Id: 47737 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A9B56B7D69 for ; Mon, 15 Mar 2010 10:01:55 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934527Ab0CNXBN (ORCPT ); Sun, 14 Mar 2010 19:01:13 -0400 Received: from gimli.pxnet.com ([195.227.45.7]:59828 "EHLO mail.pxnet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932825Ab0CNXBE (ORCPT ); Sun, 14 Mar 2010 19:01:04 -0400 Received: from xenon.ts.pxnet.com ([10.8.0.10]) (user=ts author=<> mech=DIGEST-MD5 bits=0) by mail.pxnet.com (8.13.8/8.13.8) with ESMTP id o2EN0doK018795 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 15 Mar 2010 00:00:43 +0100 Received: by xenon.ts.pxnet.com (Postfix, from userid 1000) id 2EECD40115; Sun, 14 Mar 2010 23:58:05 +0100 (CET) Message-Id: <3ba816ff92f2dad24a5265f8f213a63debe9c6e6.1268580322.git.tilman@imap.cc> In-Reply-To: References: From: Tilman Schmidt Subject: [PATCH 3/3] gigaset: prune use of tty_buffer_request_room To: Karsten Keil , David Miller CC: Hansjoerg Lipp , Alan Cox , isdn4linux , i4ldeveloper , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Sun, 14 Mar 2010 23:58:05 +0100 (CET) X-Spam-Score: -2.189 () AWL,BAYES_00,RDNS_NONE X-Scanned-By: MIMEDefang 2.67 on 195.227.45.7 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Calling tty_buffer_request_room() before tty_insert_flip_string() is unnecessary, costs CPU and for big buffers can mess up the multi-page allocation avoidance. Signed-off-by: Tilman Schmidt CC: Alan Cox , stable@kernel.org --- Note to -stable: applies correctly to 2.6.33 with fuzz 2. drivers/isdn/gigaset/interface.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c index a1bcbc2..f0dc6c9 100644 --- a/drivers/isdn/gigaset/interface.c +++ b/drivers/isdn/gigaset/interface.c @@ -628,7 +628,6 @@ void gigaset_if_receive(struct cardstate *cs, if (tty == NULL) gig_dbg(DEBUG_IF, "receive on closed device"); else { - tty_buffer_request_room(tty, len); tty_insert_flip_string(tty, buffer, len); tty_flip_buffer_push(tty); }