| Message ID | 3b45d118-4272-cf1c-143c-7e1e06fdc5ac@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YbOOtc/5"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40Qdqm5PRLz9s1d for <patchwork-incoming-netdev@ozlabs.org>; Wed, 18 Apr 2018 07:36:52 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753128AbeDQVgt (ORCPT <rfc822;patchwork-incoming-netdev@ozlabs.org>); Tue, 17 Apr 2018 17:36:49 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:41200 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752658AbeDQVgn (ORCPT <rfc822;netdev@vger.kernel.org>); Tue, 17 Apr 2018 17:36:43 -0400 Received: by mail-wr0-f195.google.com with SMTP id v24so22324468wra.8 for <netdev@vger.kernel.org>; Tue, 17 Apr 2018 14:36:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=SbnNzcvr3WYMbUVEsAKU27U04l8iVJjKhUZAEVm1EgQ=; b=YbOOtc/5clo5n7JweKL2IWcU6A1LnzkS3g4LtuWa8xPuE+LLu70ATtO49arxJEHjEI KtW9KQLYe/AAcmf5FGVHSyC0rinml9YnB1ml9Q06DK/rdYjSF85y8oXxqIpu20ZMvEV9 D4nmzauGlDHEK3fbux/eb8yBgWvZgcVF0bcnCIPH3dbxDMJlvV8lICDB+sxEBJnLBStI QtCJErvdWsoD9gmN9RhNtpGTvx5inzIyhiSdRe/1yBPj3tFFu/CAhaWwZ1s8sJ4CaVra mrYKlvV7jwFt0ajzmJhI09fNsTZZx46A7GEeeUlQJue9NNgWDt6+wYzz42Mff3hVhj0s upDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=SbnNzcvr3WYMbUVEsAKU27U04l8iVJjKhUZAEVm1EgQ=; b=RKQ2KZE057ny4Csevf9xOPMf6pEelESAaGE0PGwP9gWIvSF5h96rc4I6Rx4nU5uCq4 rt367aokt+b1u8iOQV1N3s9A3Vp1nJh7I0niggU3pHnYgQs0gTlS36c+7kKKA11G2A6c Hr9EKKLUW5AKxO7uyDRUjRWHALOxETEN5ppBn/nE40PQ3BcWJtvruFo62anqG7kMlLgW cQetn0z/H0PMj6EmG98IXuLe0XyzeCKGJLUzL4keK35p565CwUbyzlfbyQb2/dZhCuWC Fou1+IU8KUTw1ZWLRB0dA2s6oIVUuGFyjjdbqzqQL4Cs8VFM2VCwfT13Rrp7FeoLhcqO NoTw== X-Gm-Message-State: ALQs6tD0vRbnBLK+LkMXvyrXF67nN/IIoR8mFA7mjRc/Oq2i9gaYtmA/ YaZbU5q8ss29RfUCBsrqUMNM7A== X-Google-Smtp-Source: AIpwx4/onAPpenxqARzmJtHbE5Pd94F9ufz5MGMllOUCbsdsJjLSEnr1neXPUg2DQ46TIuoeXbKzew== X-Received: by 10.28.92.211 with SMTP id q202mr2099237wmb.131.1524001001670; Tue, 17 Apr 2018 14:36:41 -0700 (PDT) Received: from ?IPv6:2003:ea:8bd4:3d00:f08f:8edb:1bd1:a1a? (p200300EA8BD43D00F08F8EDB1BD10A1A.dip0.t-ipconnect.de. [2003:ea:8bd4:3d00:f08f:8edb:1bd1:a1a]) by smtp.googlemail.com with ESMTPSA id 14sm14948599wmo.27.2018.04.17.14.36.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Apr 2018 14:36:41 -0700 (PDT) Subject: [PATCH net-next 08/19] r8169: remove unneeded check in rtl8169_rx_fill From: Heiner Kallweit <hkallweit1@gmail.com> To: David Miller <davem@davemloft.net>, Realtek linux nic maintainers <nic_swsd@realtek.com> Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org> References: <4049e598-1b6c-bc3e-a905-178b76d7b161@gmail.com> Message-ID: <3b45d118-4272-cf1c-143c-7e1e06fdc5ac@gmail.com> Date: Tue, 17 Apr 2018 23:24:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <4049e598-1b6c-bc3e-a905-178b76d7b161@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
| Series |
r8169: series with further smaller improvements
|
expand
|
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 3971d089..d2d0940e 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -6784,9 +6784,6 @@ static int rtl8169_rx_fill(struct rtl8169_private *tp) for (i = 0; i < NUM_RX_DESC; i++) { void *data; - if (tp->Rx_databuff[i]) - continue; - data = rtl8169_alloc_rx_data(tp, tp->RxDescArray + i); if (!data) { rtl8169_make_unusable_by_asic(tp->RxDescArray + i);
rtl8169_rx_fill() is called only once and directly before the call array tp->Rx_databuff[] is filled with zero's. Therefore we don't need this check. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/realtek/r8169.c | 3 --- 1 file changed, 3 deletions(-)