Message ID | 3705737.6TGxRxdFzW@wuerfel |
---|---|
State | Not Applicable, archived |
Delegated to: | David Miller |
Headers | show |
On Mon, Jan 04, 2016 at 11:07:41PM +0100, Arnd Bergmann wrote: > On Monday 04 January 2016 16:50:25 Mark Brown wrote: > > On Mon, Jan 04, 2016 at 12:12:20PM +0000, Build bot for Mark Brown wrote: > > and various other linker errors caused by the fact that the new fman > > driver uses PHYLIB but does not depend on or select it. > This is the patch I submitted for the problem. I don't think that simply > adding the 'select' would be a good idea because that would force PHYLIB > builtin for allmodconfig. Indeed, that was why I held off on my own patch - I wanted to go back and try to understand why we were using a bool there.
diff --git a/drivers/net/ethernet/freescale/fman/Kconfig b/drivers/net/ethernet/freescale/fman/Kconfig index 66b729692b48..79b7c84b7869 100644 --- a/drivers/net/ethernet/freescale/fman/Kconfig +++ b/drivers/net/ethernet/freescale/fman/Kconfig @@ -1,7 +1,8 @@ config FSL_FMAN - bool "FMan support" + tristate "FMan support" depends on FSL_SOC || COMPILE_TEST select GENERIC_ALLOCATOR + select PHYLIB default n help Freescale Data-Path Acceleration Architecture Frame Manager