diff mbox series

[26/33] netxen_nic: Mark expected switch fall-throughs

Message ID	27059b065b37c33381219fba31648f7d0d565d39.1533675546.git.gustavo@embeddedor.com
State	Accepted, archived
Delegated to:	David Miller
Headers	show Return-Path: <netdev-owner@vger.kernel.org> Date: Tue, 7 Aug 2018 18:26:49 -0500 From: "Gustavo A. R. Silva" <gustavo@embeddedor.com> To: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" <gustavo@embeddedor.com> Cc: Manish Chopra <manish.chopra@cavium.com>, Rahul Verma <rahul.verma@cavium.com>, Dept-GELinuxNICDev@cavium.com Subject: [PATCH 26/33] netxen_nic: Mark expected switch fall-throughs Message-ID: <27059b065b37c33381219fba31648f7d0d565d39.1533675546.git.gustavo@embeddedor.com> References: <cover.1533675546.git.gustavo@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <cover.1533675546.git.gustavo@embeddedor.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: netdev-owner@vger.kernel.org Precedence: bulk
Series	net: ethernet: Mark expected switch fall-throughs \| expand [00/33] net: ethernet: Mark expected switch fall-throughs [01/33] 8390: axnet_cs: Mark expected switch fall-through [02/33] alteon: acenic: mark expected switch fall-through [03/33] bnx2x: Mark expected switch fall-thoughs [04/33] net: macb: Mark expected switch fall-through [05/33] liquidio: mark expected switch fall-through [06/33] cxgb4/l2t: Mark expected switch fall-through [07/33] cxgb4/t4_hw: mark expected switch fall-throughs [08/33] cxgb3/l2t: Mark expected switch fall-through [09/33] net: thunderx: mark expected switch fall-through [10/33] net: tulip_core: mark expected switch fall-through [11/33] net: tulip: de4x5: mark expected switch fall-throughs [12/33] be2net: Mark expected switch fall-through [13/33] net: hns: Mark expected switch fall-through [14/33] net: hns3: Mark expected switch fall-through [15/33] i40e_main: mark expected switch fall-through [16/33] i40e_txrx: mark expected switch fall-through [17/33] net/mlx4/mcg: Mark expected switch fall-throughs [18/33] net/mlx4/en_rx: Mark expected switch fall-throughs [19/33] igb_main: Mark expected switch fall-throughs [20/33] igb: e1000_82575: Mark expected switch fall-through [21/33] igb: e1000_phy: Mark expected switch fall-through [22/33] igbvf: netdev: Mark expected switch fall-through [23/33] vxge: Mark expected switch fall-throughs [24/33] net/mlx5e: Mark expected switch fall-throughs [25/33] qed: qed_dev: Mark expected switch fall-throughs [26/33] netxen_nic: Mark expected switch fall-throughs [27/33] qede: qede_fp: Mark expected switch fall-through [28/33] qlcnic: Mark expected switch fall-througs [29/33] qlge: mark expected switch fall-through [30/33] net: ethernet: sxgbe: mark expected switch fall-throughs [31/33] net: sfc: falcon: mark expected switch fall-through [32/33] net: tlan: Mark expected switch fall-through [33/33] net: ethernet: ti: cpts: mark expected switch fall-through

Commit Message

Gustavo A. R. Silva Aug. 7, 2018, 11:26 p.m. UTC

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1410182 ("Missing break in switch")
Addresses-Coverity-ID: 1410183 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c
index 3157f97..3c1be87 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c
@@ -167,9 +167,9 @@  netxen_nic_get_link_ksettings(struct net_device *dev,
 	case NETXEN_BRDTYPE_P3_REF_QG:
 	case NETXEN_BRDTYPE_P3_4_GB:
 	case NETXEN_BRDTYPE_P3_4_GB_MM:
-
 		supported |= SUPPORTED_Autoneg;
 		advertising |= ADVERTISED_Autoneg;
+		/* fall through */
 	case NETXEN_BRDTYPE_P2_SB31_10G_CX4:
 	case NETXEN_BRDTYPE_P3_10G_CX4:
 	case NETXEN_BRDTYPE_P3_10G_CX4_LP:
@@ -198,6 +198,7 @@  netxen_nic_get_link_ksettings(struct net_device *dev,
 		supported |= SUPPORTED_TP;
 		check_sfp_module = netif_running(dev) &&
 			adapter->has_link_events;
+		/* fall through */
 	case NETXEN_BRDTYPE_P2_SB31_10G:
 	case NETXEN_BRDTYPE_P3_10G_XFP:
 		supported |= SUPPORTED_FIBRE;