diff mbox series

[v2,net-next,1/4] net: bonding: Notify ports about their initial state

Message ID 20201130140610.4018-2-tobias@waldekranz.com
State New
Headers show
Series net: dsa: Link aggregation support | expand

Commit Message

Tobias Waldekranz Nov. 30, 2020, 2:06 p.m. UTC
When creating a static bond (e.g. balance-xor), all ports will always
be enabled. This is set, and the corresponding notification is sent
out, before the port is linked to the bond upper.

In the offloaded case, this ordering is hard to deal with.

The lower will first see a notification that it can not associate with
any bond. Then the bond is joined. After that point no more
notifications are sent, so all ports remain disabled.

This change simply sends an extra notification once the port has been
linked to the upper to synchronize the initial state.

Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
 drivers/net/bonding/bond_main.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series


diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index e0880a3840d7..d6e1f9cf28d5 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1922,6 +1922,8 @@  int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev,
 		goto err_unregister;
+	bond_lower_state_changed(new_slave);
 	res = bond_sysfs_slave_add(new_slave);
 	if (res) {
 		slave_dbg(bond_dev, slave_dev, "Error %d calling bond_sysfs_slave_add\n", res);