Message ID | 20201122002336.79912-1-ezequiel@collabora.com |
---|---|
State | Superseded |
Headers | show |
Series | dpaa2-eth: Fix compile error due to missing devlink support | expand |
Hi Ezequiel, Thanks a lot for the fix, I overlooked this when adding devlink support. On Sat, Nov 21, 2020 at 09:23:36PM -0300, Ezequiel Garcia wrote: > The dpaa2 driver depends on devlink, so it should select > NET_DEVLINK in order to fix compile errors, such as: > > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.o: in function `dpaa2_eth_rx_err': > dpaa2-eth.c:(.text+0x3cec): undefined reference to `devlink_trap_report' > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function `dpaa2_eth_dl_info_get': > dpaa2-eth-devlink.c:(.text+0x160): undefined reference to `devlink_info_driver_name_put' > What tree is this intended for? Maybe add a fixes tag and send this towards the net tree? Ioana > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > --- > drivers/net/ethernet/freescale/dpaa2/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/freescale/dpaa2/Kconfig b/drivers/net/ethernet/freescale/dpaa2/Kconfig > index cfd369cf4c8c..aee59ead7250 100644 > --- a/drivers/net/ethernet/freescale/dpaa2/Kconfig > +++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig > @@ -2,6 +2,7 @@ > config FSL_DPAA2_ETH > tristate "Freescale DPAA2 Ethernet" > depends on FSL_MC_BUS && FSL_MC_DPIO > + select NET_DEVLINK > select PHYLINK > select PCS_LYNX > help > -- > 2.27.0 >
Hi Ioana, On Mon, 2020-11-23 at 09:39 +0000, Ioana Ciornei wrote: > Hi Ezequiel, > > Thanks a lot for the fix, I overlooked this when adding devlink support. > No worries :) > On Sat, Nov 21, 2020 at 09:23:36PM -0300, Ezequiel Garcia wrote: > > The dpaa2 driver depends on devlink, so it should select > > NET_DEVLINK in order to fix compile errors, such as: > > > > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.o: in function `dpaa2_eth_rx_err': > > dpaa2-eth.c:(.text+0x3cec): undefined reference to `devlink_trap_report' > > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function `dpaa2_eth_dl_info_get': > > dpaa2-eth-devlink.c:(.text+0x160): undefined reference to `devlink_info_driver_name_put' > > > > What tree is this intended for? > Oops, I forgot about netdev rules. I guess I haven't sent a net patch in a long time. This patch is a fix, so I guess it's for the 'net' tree. > Maybe add a fixes tag and send this towards the net tree? > Would you mind too much taking care of this, putting the Fixes you think matches best? That would be really appreciated! Thanks, Ezequiel > Ioana > > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > > --- > > drivers/net/ethernet/freescale/dpaa2/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/ethernet/freescale/dpaa2/Kconfig b/drivers/net/ethernet/freescale/dpaa2/Kconfig > > index cfd369cf4c8c..aee59ead7250 100644 > > --- a/drivers/net/ethernet/freescale/dpaa2/Kconfig > > +++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig > > @@ -2,6 +2,7 @@ > > config FSL_DPAA2_ETH > > tristate "Freescale DPAA2 Ethernet" > > depends on FSL_MC_BUS && FSL_MC_DPIO > > + select NET_DEVLINK > > select PHYLINK > > select PCS_LYNX > > help > > -- > > 2.27.0
On Mon, Nov 23, 2020 at 12:06:14PM -0300, Ezequiel Garcia wrote: > Hi Ioana, > > On Mon, 2020-11-23 at 09:39 +0000, Ioana Ciornei wrote: > > Hi Ezequiel, > > > > Thanks a lot for the fix, I overlooked this when adding devlink support. > > > > No worries :) > > > On Sat, Nov 21, 2020 at 09:23:36PM -0300, Ezequiel Garcia wrote: > > > The dpaa2 driver depends on devlink, so it should select > > > NET_DEVLINK in order to fix compile errors, such as: > > > > > > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.o: in function `dpaa2_eth_rx_err': > > > dpaa2-eth.c:(.text+0x3cec): undefined reference to `devlink_trap_report' > > > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function `dpaa2_eth_dl_info_get': > > > dpaa2-eth-devlink.c:(.text+0x160): undefined reference to `devlink_info_driver_name_put' > > > > > > > What tree is this intended for? > > > > Oops, I forgot about netdev rules. I guess I haven't sent > a net patch in a long time. > > This patch is a fix, so I guess it's for the 'net' tree. > > > Maybe add a fixes tag and send this towards the net tree? > > > > Would you mind too much taking care of this, putting the > Fixes you think matches best? > > That would be really appreciated! > Sure, I'll respin this. Ioana
diff --git a/drivers/net/ethernet/freescale/dpaa2/Kconfig b/drivers/net/ethernet/freescale/dpaa2/Kconfig index cfd369cf4c8c..aee59ead7250 100644 --- a/drivers/net/ethernet/freescale/dpaa2/Kconfig +++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig @@ -2,6 +2,7 @@ config FSL_DPAA2_ETH tristate "Freescale DPAA2 Ethernet" depends on FSL_MC_BUS && FSL_MC_DPIO + select NET_DEVLINK select PHYLINK select PCS_LYNX help
The dpaa2 driver depends on devlink, so it should select NET_DEVLINK in order to fix compile errors, such as: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.o: in function `dpaa2_eth_rx_err': dpaa2-eth.c:(.text+0x3cec): undefined reference to `devlink_trap_report' drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function `dpaa2_eth_dl_info_get': dpaa2-eth-devlink.c:(.text+0x160): undefined reference to `devlink_info_driver_name_put' Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> --- drivers/net/ethernet/freescale/dpaa2/Kconfig | 1 + 1 file changed, 1 insertion(+)