| Message ID | 20201112153537.22383-6-ceggers@arri.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | net: dsa: microchip: PTP support for KSZ956x | expand |
On Thu, Nov 12, 2020 at 04:35:31PM +0100, Christian Eggers wrote: > The devices have an optional interrupt line. > > Signed-off-by: Christian Eggers <ceggers@arri.de> > --- > .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > index 431ca5c498a8..b2613d6c97cf 100644 > --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > @@ -35,6 +35,11 @@ properties: > Should be a gpio specifier for a reset line. > maxItems: 1 > > + interrupts: > + description: > + Interrupt specifier for the INTRP_N line from the device. > + maxItems: 1 > + > microchip,synclko-125: > $ref: /schemas/types.yaml#/definitions/flag > description: > @@ -47,6 +52,7 @@ required: > examples: > - | > #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > > // Ethernet switch connected via SPI to the host, CPU port wired to eth0: > eth0 { > @@ -68,6 +74,8 @@ examples: > compatible = "microchip,ksz9477"; > reg = <0>; > reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; > + interrupt-parent = <&gpio5>; > + interrupts = <1 IRQ_TYPE_LEVEL_LOW>; /* INTRP_N line */ Isn't it preferable to use this syntax? interrupts-extended = <&gpio5 1 IRQ_TYPE_LEVEL_LOW>; /* INTRP_N line */
On Friday, 13 November 2020, 00:07:32 CET, Vladimir Oltean wrote: > On Thu, Nov 12, 2020 at 04:35:31PM +0100, Christian Eggers wrote: > > The devices have an optional interrupt line. > > > > Signed-off-by: Christian Eggers <ceggers@arri.de> > > --- > > > > .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > > b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml index > > 431ca5c498a8..b2613d6c97cf 100644 > > --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > > +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > > ... > > + interrupt-parent = <&gpio5>; > > + interrupts = <1 IRQ_TYPE_LEVEL_LOW>; /* INTRP_N line */ > > Isn't it preferable to use this syntax? > > interrupts-extended = <&gpio5 1 IRQ_TYPE_LEVEL_LOW>; /* INTRP_N line */ After reading Documentation/devicetree/bindings/interrupt-controller/interrupts.txt, I would say that "interrupts-extended" is more flexible as it allows different interrupt parents for the case there is more than one interrupt line. Although there is only one line on the KSZ, I will change this.
diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml index 431ca5c498a8..b2613d6c97cf 100644 --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml @@ -35,6 +35,11 @@ properties: Should be a gpio specifier for a reset line. maxItems: 1 + interrupts: + description: + Interrupt specifier for the INTRP_N line from the device. + maxItems: 1 + microchip,synclko-125: $ref: /schemas/types.yaml#/definitions/flag description: @@ -47,6 +52,7 @@ required: examples: - | #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> // Ethernet switch connected via SPI to the host, CPU port wired to eth0: eth0 { @@ -68,6 +74,8 @@ examples: compatible = "microchip,ksz9477"; reg = <0>; reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; + interrupt-parent = <&gpio5>; + interrupts = <1 IRQ_TYPE_LEVEL_LOW>; /* INTRP_N line */ spi-max-frequency = <44000000>; spi-cpha;
The devices have an optional interrupt line. Signed-off-by: Christian Eggers <ceggers@arri.de> --- .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)