| Message ID | 20201026112257.1371229-1-vladimir.oltean@nxp.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] net: mscc: ocelot: populate the entry type in ocelot_mact_read | expand |
| Context | Check | Description |
|---|---|---|
| jkicinski/cover_letter | success | Link |
| jkicinski/fixes_present | success | Link |
| jkicinski/patch_count | success | Link |
| jkicinski/tree_selection | success | Clearly marked for net |
| jkicinski/subject_prefix | success | Link |
| jkicinski/source_inline | success | Was 0 now: 0 |
| jkicinski/verify_signedoff | success | Link |
| jkicinski/module_param | success | Was 0 now: 0 |
| jkicinski/build_32bit | fail | Errors and warnings before: 4 this patch: 4 |
| jkicinski/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/verify_fixes | fail | Link |
| jkicinski/checkpatch | fail | Link |
| jkicinski/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/header_inline | success | Link |
| jkicinski/stable | success | Stable not CCed |
On Mon, 26 Oct 2020 13:22:57 +0200 Vladimir Oltean wrote: > Currently this boolean in ocelot_fdb_dump will always be set to false: > > is_static = (entry.type == ENTRYTYPE_LOCKED); > > Fix it by ensuring the entry type is always read from hardware. > > Fixes: 64bfb05b74ad ("net: mscc: ocelot: break out fdb operations into abstract implementations") > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Fixes tag: Fixes: 64bfb05b74ad ("net: mscc: ocelot: break out fdb operations into abstract implementations") Has these problem(s): - Target SHA1 does not exist
diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c index 70bf8c67d7ef..860cd2390670 100644 --- a/drivers/net/ethernet/mscc/ocelot.c +++ b/drivers/net/ethernet/mscc/ocelot.c @@ -647,6 +647,8 @@ static int ocelot_mact_read(struct ocelot *ocelot, int port, int row, int col, if (dst != port) return -EINVAL; + entry->type = ANA_TABLES_MACACCESS_ENTRYTYPE_X(val); + /* Get the entry's MAC address and VLAN id */ macl = ocelot_read(ocelot, ANA_TABLES_MACLDATA); mach = ocelot_read(ocelot, ANA_TABLES_MACHDATA);
Currently this boolean in ocelot_fdb_dump will always be set to false: is_static = (entry.type == ENTRYTYPE_LOCKED); Fix it by ensuring the entry type is always read from hardware. Fixes: 64bfb05b74ad ("net: mscc: ocelot: break out fdb operations into abstract implementations") Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- drivers/net/ethernet/mscc/ocelot.c | 2 ++ 1 file changed, 2 insertions(+)