| Message ID | 20201006165606.7313-1-W_Armin@gmx.de |
|---|---|
| State | Rejected |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] ne2k-pci: Enable RW-Bugfix | expand |
On Tue, 6 Oct 2020 18:56:06 +0200 Armin Wolf wrote: > Enable the ne2k-pci Read-before-Write Bugfix > since not doing so could (according to the Datasheet) > cause the system to lock up with some chips. > > Signed-off-by: Armin Wolf <W_Armin@gmx.de> > --- > drivers/net/ethernet/8390/ne2k-pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/8390/ne2k-pci.c b/drivers/net/ethernet/8390/ne2k-pci.c > index bc6edb3f1af3..a1319cd86ab9 100644 > --- a/drivers/net/ethernet/8390/ne2k-pci.c > +++ b/drivers/net/ethernet/8390/ne2k-pci.c > @@ -91,7 +91,7 @@ MODULE_PARM_DESC(full_duplex, "full duplex setting(s) (1)"); > #define USE_LONGIO > > /* Do we implement the read before write bugfix ? */ > -/* #define NE_RW_BUGFIX */ > +#define NE_RW_BUGFIX This doesn't do anything, does it: $ git grep NE_RW_BUGFIX drivers/net/ethernet/8390/ne.c:/* #define NE_RW_BUGFIX */ drivers/net/ethernet/8390/ne2k-pci.c:/* #define NE_RW_BUGFIX */
diff --git a/drivers/net/ethernet/8390/ne2k-pci.c b/drivers/net/ethernet/8390/ne2k-pci.c index bc6edb3f1af3..a1319cd86ab9 100644 --- a/drivers/net/ethernet/8390/ne2k-pci.c +++ b/drivers/net/ethernet/8390/ne2k-pci.c @@ -91,7 +91,7 @@ MODULE_PARM_DESC(full_duplex, "full duplex setting(s) (1)"); #define USE_LONGIO /* Do we implement the read before write bugfix ? */ -/* #define NE_RW_BUGFIX */ +#define NE_RW_BUGFIX /* Flags. We rename an existing ei_status field to store flags! * Thus only the low 8 bits are usable for non-init-time flags.
Enable the ne2k-pci Read-before-Write Bugfix since not doing so could (according to the Datasheet) cause the system to lock up with some chips. Signed-off-by: Armin Wolf <W_Armin@gmx.de> --- drivers/net/ethernet/8390/ne2k-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1