diff mbox series

[bpf-next] xsk: remove internal DMA headers

Message ID 20201005090525.116689-1-bjorn.topel@gmail.com
State Accepted
Delegated to: BPF Maintainers
Headers show
Series [bpf-next] xsk: remove internal DMA headers | expand

Commit Message

Björn Töpel Oct. 5, 2020, 9:05 a.m. UTC 
From: Björn Töpel <bjorn.topel@intel.com>

Christoph Hellwig correctly pointed out [1] that the AF_XDP core was
pointlessly including internal headers. Let us remove those includes.

[1] https://lore.kernel.org/bpf/20201005084341.GA3224@infradead.org/

Reported-by: Christoph Hellwig <hch@infradead.org>
Fixes: 1c1efc2af158 ("xsk: Create and free buffer pool independently from umem")
Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
---
 net/xdp/xsk_buff_pool.c | 3 ---
 1 file changed, 3 deletions(-)


base-commit: 1028ae4069991e26d1522e957939fb61d2da1d12

Comments

Christoph Hellwig Oct. 5, 2020, 9:06 a.m. UTC | #1 
On Mon, Oct 05, 2020 at 11:05:25AM +0200, Bj??rn T??pel wrote:
> From: Bj??rn T??pel <bjorn.topel@intel.com>
> 
> Christoph Hellwig correctly pointed out [1] that the AF_XDP core was
> pointlessly including internal headers. Let us remove those includes.
> 
> [1] https://lore.kernel.org/bpf/20201005084341.GA3224@infradead.org/
> 
> Reported-by: Christoph Hellwig <hch@infradead.org>
> Fixes: 1c1efc2af158 ("xsk: Create and free buffer pool independently from umem")
> Signed-off-by: Bj??rn T??pel <bjorn.topel@intel.com>

Thanks:

Acked-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/net/xdp/xsk_buff_pool.c b/net/xdp/xsk_buff_pool.c
index e63fadd000db..64c9e55d4d4e 100644
--- a/net/xdp/xsk_buff_pool.c
+++ b/net/xdp/xsk_buff_pool.c
@@ -3,9 +3,6 @@ 
 #include <net/xsk_buff_pool.h>
 #include <net/xdp_sock.h>
 #include <net/xdp_sock_drv.h>
-#include <linux/dma-direct.h>
-#include <linux/dma-noncoherent.h>
-#include <linux/swiotlb.h>
 
 #include "xsk_queue.h"
 #include "xdp_umem.h"