diff mbox series

[net-next] net/appletalk: Supply missing net/Space.h include file

Message ID 20200918125551.12075-1-wanghai38@huawei.com
State Accepted
Delegated to: David Miller
Headers show
Series [net-next] net/appletalk: Supply missing net/Space.h include file | expand

Commit Message

Wang Hai Sept. 18, 2020, 12:55 p.m. UTC
If the header file containing a function's prototype isn't included by
the sourcefile containing the associated function, the build system
complains of missing prototypes.

Fixes the following W=1 kernel build warning(s):

drivers/net/appletalk/cops.c:213:28: warning: no previous prototype for ‘cops_probe’ [-Wmissing-prototypes]
drivers/net/appletalk/ltpc.c:1014:28: warning: no previous prototype for ‘ltpc_probe’ [-Wmissing-prototypes]

Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
 drivers/net/appletalk/cops.c | 2 ++
 drivers/net/appletalk/ltpc.c | 2 ++
 2 files changed, 4 insertions(+)

Comments

David Miller Sept. 18, 2020, 9:53 p.m. UTC | #1
From: Wang Hai <wanghai38@huawei.com>
Date: Fri, 18 Sep 2020 20:55:51 +0800

> If the header file containing a function's prototype isn't included by
> the sourcefile containing the associated function, the build system
> complains of missing prototypes.
> 
> Fixes the following W=1 kernel build warning(s):
> 
> drivers/net/appletalk/cops.c:213:28: warning: no previous prototype for ‘cops_probe’ [-Wmissing-prototypes]
> drivers/net/appletalk/ltpc.c:1014:28: warning: no previous prototype for ‘ltpc_probe’ [-Wmissing-prototypes]
> 
> Signed-off-by: Wang Hai <wanghai38@huawei.com>

Applied.
diff mbox series

Patch

diff --git a/drivers/net/appletalk/cops.c b/drivers/net/appletalk/cops.c
index 1c6c27f35ac4..ba8e70a8e312 100644
--- a/drivers/net/appletalk/cops.c
+++ b/drivers/net/appletalk/cops.c
@@ -70,6 +70,8 @@  static const char *version =
 #include <linux/bitops.h>
 #include <linux/jiffies.h>
 
+#include <net/Space.h>
+
 #include <asm/io.h>
 #include <asm/dma.h>
 
diff --git a/drivers/net/appletalk/ltpc.c b/drivers/net/appletalk/ltpc.c
index 75a5a9b87c5a..c6f73aa3700c 100644
--- a/drivers/net/appletalk/ltpc.c
+++ b/drivers/net/appletalk/ltpc.c
@@ -229,6 +229,8 @@  static int dma;
 #include <linux/bitops.h>
 #include <linux/gfp.h>
 
+#include <net/Space.h>
+
 #include <asm/dma.h>
 #include <asm/io.h>