| Message ID | 20200917184243.11994-1-snelson@pensando.io |
|---|---|
| State | Superseded |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] ionic: add DIMLIB to Kconfig | expand |
On Thu, 17 Sep 2020 11:42:43 -0700 Shannon Nelson wrote: > >> ld.lld: error: undefined symbol: net_dim_get_rx_moderation > >>> referenced by ionic_lif.c:52 (drivers/net/ethernet/pensando/ionic/ionic_lif.c:52) > >>> net/ethernet/pensando/ionic/ionic_lif.o:(ionic_dim_work) in archive drivers/built-in.a > -- This is going to cut off the commit message when patch is applied. > >> ld.lld: error: undefined symbol: net_dim > >>> referenced by ionic_txrx.c:456 (drivers/net/ethernet/pensando/ionic/ionic_txrx.c:456) > >>> net/ethernet/pensando/ionic/ionic_txrx.o:(ionic_dim_update) in archive drivers/built-in.a > > Fixes: 04a834592bf5 ("ionic: dynamic interrupt moderation") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Shannon Nelson <snelson@pensando.io>
On 9/17/20 12:02 PM, Jakub Kicinski wrote: > On Thu, 17 Sep 2020 11:42:43 -0700 Shannon Nelson wrote: >>>> ld.lld: error: undefined symbol: net_dim_get_rx_moderation >> >>> referenced by ionic_lif.c:52 (drivers/net/ethernet/pensando/ionic/ionic_lif.c:52) >> >>> net/ethernet/pensando/ionic/ionic_lif.o:(ionic_dim_work) in archive drivers/built-in.a >> -- > This is going to cut off the commit message when patch is applied. Isn't the trigger a three dash string? It is only two dashes, not three, and "git am" seems to work correctly for me. Is there a different mechanism I need to watch out for? sln > >>>> ld.lld: error: undefined symbol: net_dim >> >>> referenced by ionic_txrx.c:456 (drivers/net/ethernet/pensando/ionic/ionic_txrx.c:456) >> >>> net/ethernet/pensando/ionic/ionic_txrx.o:(ionic_dim_update) in archive drivers/built-in.a >> >> Fixes: 04a834592bf5 ("ionic: dynamic interrupt moderation") >> Reported-by: kernel test robot <lkp@intel.com> >> Signed-off-by: Shannon Nelson <snelson@pensando.io>
On Thu, 17 Sep 2020 12:08:45 -0700 Shannon Nelson wrote: > On 9/17/20 12:02 PM, Jakub Kicinski wrote: > > On Thu, 17 Sep 2020 11:42:43 -0700 Shannon Nelson wrote: > >>>> ld.lld: error: undefined symbol: net_dim_get_rx_moderation > >> >>> referenced by ionic_lif.c:52 (drivers/net/ethernet/pensando/ionic/ionic_lif.c:52) > >> >>> net/ethernet/pensando/ionic/ionic_lif.o:(ionic_dim_work) in archive drivers/built-in.a > >> -- > > This is going to cut off the commit message when patch is applied. > > Isn't the trigger a three dash string? It is only two dashes, not > three, and "git am" seems to work correctly for me. Is there a > different mechanism I need to watch out for? I got a verify_signoff failure on this patch: Commit a92faed54662 ("ionic: add DIMLIB to Kconfig") author Signed-off-by missing author email: snelson@pensando.io And in the tree I can see the commit got cut off. Maybe it's some extra mangling my bot does. In any case, I wanted to at least give Dave a heads up.
From: Jakub Kicinski <kuba@kernel.org> Date: Thu, 17 Sep 2020 13:02:31 -0700 > On Thu, 17 Sep 2020 12:08:45 -0700 Shannon Nelson wrote: >> On 9/17/20 12:02 PM, Jakub Kicinski wrote: >> > On Thu, 17 Sep 2020 11:42:43 -0700 Shannon Nelson wrote: >> >>>> ld.lld: error: undefined symbol: net_dim_get_rx_moderation >> >> >>> referenced by ionic_lif.c:52 (drivers/net/ethernet/pensando/ionic/ionic_lif.c:52) >> >> >>> net/ethernet/pensando/ionic/ionic_lif.o:(ionic_dim_work) in archive drivers/built-in.a >> >> -- >> > This is going to cut off the commit message when patch is applied. >> >> Isn't the trigger a three dash string? It is only two dashes, not >> three, and "git am" seems to work correctly for me. Is there a >> different mechanism I need to watch out for? > > I got a verify_signoff failure on this patch: > > Commit a92faed54662 ("ionic: add DIMLIB to Kconfig") > author Signed-off-by missing > author email: snelson@pensando.io > > And in the tree I can see the commit got cut off. > > Maybe it's some extra mangling my bot does. In any case, I wanted to > at least give Dave a heads up. Thanks I'll watch carefully when applying this :)
On 9/17/20 1:02 PM, Jakub Kicinski wrote: > On Thu, 17 Sep 2020 12:08:45 -0700 Shannon Nelson wrote: >> On 9/17/20 12:02 PM, Jakub Kicinski wrote: >>> On Thu, 17 Sep 2020 11:42:43 -0700 Shannon Nelson wrote: >>>>>> ld.lld: error: undefined symbol: net_dim_get_rx_moderation >>>> >>> referenced by ionic_lif.c:52 (drivers/net/ethernet/pensando/ionic/ionic_lif.c:52) >>>> >>> net/ethernet/pensando/ionic/ionic_lif.o:(ionic_dim_work) in archive drivers/built-in.a >>>> -- >>> This is going to cut off the commit message when patch is applied. >> Isn't the trigger a three dash string? It is only two dashes, not >> three, and "git am" seems to work correctly for me. Is there a >> different mechanism I need to watch out for? > I got a verify_signoff failure on this patch: > > Commit a92faed54662 ("ionic: add DIMLIB to Kconfig") > author Signed-off-by missing > author email: snelson@pensando.io > > And in the tree I can see the commit got cut off. > > Maybe it's some extra mangling my bot does. In any case, I wanted to > at least give Dave a heads up. Okay, thanks for the note. I'll respin without the dashes. sln
diff --git a/drivers/net/ethernet/pensando/Kconfig b/drivers/net/ethernet/pensando/Kconfig index 76f8cc502bf9..5f8b0bb3af6e 100644 --- a/drivers/net/ethernet/pensando/Kconfig +++ b/drivers/net/ethernet/pensando/Kconfig @@ -21,6 +21,7 @@ config IONIC tristate "Pensando Ethernet IONIC Support" depends on 64BIT && PCI select NET_DEVLINK + select DIMLIB help This enables the support for the Pensando family of Ethernet adapters. More specific information on this driver can be