diff mbox series

[net-next] can: kvaser_pciefd: Remove unused macro KVASER_PCIEFD_KCAN_CTRL_EFRAME

Message ID 20200904131026.21817-1-wanghai38@huawei.com
State Awaiting Upstream
Delegated to: David Miller
Headers show
Series [net-next] can: kvaser_pciefd: Remove unused macro KVASER_PCIEFD_KCAN_CTRL_EFRAME | expand

Commit Message

Wang Hai Sept. 4, 2020, 1:10 p.m. UTC
KVASER_PCIEFD_KCAN_CTRL_EFRAME is never used after it was introduced.
So better to remove it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
 drivers/net/can/kvaser_pciefd.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Marc Kleine-Budde Sept. 15, 2020, 6:31 a.m. UTC | #1
On 9/4/20 3:10 PM, Wang Hai wrote:
> KVASER_PCIEFD_KCAN_CTRL_EFRAME is never used after it was introduced.
> So better to remove it.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
>  drivers/net/can/kvaser_pciefd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c
> index 6f766918211a..c0b18ff107c7 100644
> --- a/drivers/net/can/kvaser_pciefd.c
> +++ b/drivers/net/can/kvaser_pciefd.c
> @@ -131,7 +131,6 @@ MODULE_DESCRIPTION("CAN driver for Kvaser CAN/PCIe devices");
>  
>  /* Kvaser KCAN definitions */
>  #define KVASER_PCIEFD_KCAN_CTRL_EFLUSH (4 << 29)
> -#define KVASER_PCIEFD_KCAN_CTRL_EFRAME (5 << 29)
>  
>  #define KVASER_PCIEFD_KCAN_CMD_SEQ_SHIFT 16
>  /* Request status packet */
> 

I'd like to keep this for documentation purpose, too.

Marc
diff mbox series

Patch

diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c
index 6f766918211a..c0b18ff107c7 100644
--- a/drivers/net/can/kvaser_pciefd.c
+++ b/drivers/net/can/kvaser_pciefd.c
@@ -131,7 +131,6 @@  MODULE_DESCRIPTION("CAN driver for Kvaser CAN/PCIe devices");
 
 /* Kvaser KCAN definitions */
 #define KVASER_PCIEFD_KCAN_CTRL_EFLUSH (4 << 29)
-#define KVASER_PCIEFD_KCAN_CTRL_EFRAME (5 << 29)
 
 #define KVASER_PCIEFD_KCAN_CMD_SEQ_SHIFT 16
 /* Request status packet */