diff mbox series

firestream: Fix memleak in fs_open

Message ID 20200823112935.27574-1-dinghao.liu@zju.edu.cn
State Accepted
Delegated to: David Miller
Headers show
Series firestream: Fix memleak in fs_open | expand

Commit Message

Dinghao Liu Aug. 23, 2020, 11:29 a.m. UTC 
When make_rate() fails, vcc should be freed just
like other error paths in fs_open().

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
 drivers/atm/firestream.c | 1 +
 1 file changed, 1 insertion(+)

Comments

David Miller Aug. 25, 2020, 1:03 a.m. UTC | #1 
From: Dinghao Liu <dinghao.liu@zju.edu.cn>
Date: Sun, 23 Aug 2020 19:29:35 +0800

> When make_rate() fails, vcc should be freed just
> like other error paths in fs_open().
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>

Applied, thank you.
diff mbox series

Patch

diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c
index 2ca9ec802734..510250cf5c87 100644
--- a/drivers/atm/firestream.c
+++ b/drivers/atm/firestream.c
@@ -998,6 +998,7 @@  static int fs_open(struct atm_vcc *atm_vcc)
 				error = make_rate (pcr, r, &tmc0, NULL);
 				if (error) {
 					kfree(tc);
+					kfree(vcc);
 					return error;
 				}
 			}