| Message ID | 20200806022808.GA17066@oppo |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | nfc: enforce CAP_NET_RAW for raw sockets When creating a raw AF_NFC socket, CAP_NET_RAW needs to be checked first. | expand |
On Thu, 6 Aug 2020 10:28:08 +0800 Qingyu Li wrote: Commit message is required. Perhaps shorten the subject and put more info here. > Signed-off-by: Qingyu Li <ieatmuttonchuan@gmail.com> > --- > net/nfc/rawsock.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/net/nfc/rawsock.c b/net/nfc/rawsock.c > index ba5ffd3badd3..c1302b689a98 100644 > --- a/net/nfc/rawsock.c > +++ b/net/nfc/rawsock.c > @@ -332,8 +332,11 @@ static int rawsock_create(struct net *net, struct socket *sock, > if ((sock->type != SOCK_SEQPACKET) && (sock->type != SOCK_RAW)) > return -ESOCKTNOSUPPORT; > > - if (sock->type == SOCK_RAW) > + if (sock->type == SOCK_RAW){ > + if (!capable(CAP_NET_RAW)) > + return -EPERM; > sock->ops = &rawsock_raw_ops; > + } please run checkpatch.pl --strict and fix the issues. > else > sock->ops = &rawsock_ops; > > >
diff --git a/net/nfc/rawsock.c b/net/nfc/rawsock.c index ba5ffd3badd3..c1302b689a98 100644 --- a/net/nfc/rawsock.c +++ b/net/nfc/rawsock.c @@ -332,8 +332,11 @@ static int rawsock_create(struct net *net, struct socket *sock, if ((sock->type != SOCK_SEQPACKET) && (sock->type != SOCK_RAW)) return -ESOCKTNOSUPPORT; - if (sock->type == SOCK_RAW) + if (sock->type == SOCK_RAW){ + if (!capable(CAP_NET_RAW)) + return -EPERM; sock->ops = &rawsock_raw_ops; + } else sock->ops = &rawsock_ops;
Signed-off-by: Qingyu Li <ieatmuttonchuan@gmail.com> --- net/nfc/rawsock.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)