diff mbox series

[net-next,4/9] mlxsw: spectrum_span: On policer_id_base_ref_count, use dec_and_test

Message ID 20200803161141.2523857-5-idosch@idosch.org
State Accepted
Delegated to: David Miller
Headers show
Series mlxsw: Add support for buffer drop traps | expand

Commit Message

Ido Schimmel Aug. 3, 2020, 4:11 p.m. UTC
From: Petr Machata <petrm@mellanox.com>

When unsetting policer base, the SPAN code currently uses refcount_dec().
However that function splats when the counter reaches zero, because
reaching zero without actually testing is in general indicative of a
missing cleanup. There is no cleanup to be done here, but nonetheless, use
refcount_dec_and_test() as required.

Signed-off-by: Petr Machata <petrm@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
 drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series


diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c
index 323eaf979aea..5c959a995199 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c
@@ -837,7 +837,8 @@  static int mlxsw_sp_span_policer_id_base_set(struct mlxsw_sp_span *span,
 static void mlxsw_sp_span_policer_id_base_unset(struct mlxsw_sp_span *span)
-	refcount_dec(&span->policer_id_base_ref_count);
+	if (refcount_dec_and_test(&span->policer_id_base_ref_count))
+		span->policer_id_base = 0;
 static struct mlxsw_sp_span_entry *