| Message ID | 20200730195749.4922-5-bruno.thomsen@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | Improve MDIO Ethernet PHY reset | expand |
On Thu, Jul 30, 2020 at 09:57:49PM +0200, Bruno Thomsen wrote: > MDIO device reset assert and deassert length was created by > usleep_range() but that does not ensure optimal handling of > all the different values from device tree properties. > By switching to the new flexible sleeping helper function, > fsleep(), the correct delay function is called depending on > delay length, e.g. udelay(), usleep_range() or msleep(). > > Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 7/30/2020 12:57 PM, Bruno Thomsen wrote: > MDIO device reset assert and deassert length was created by > usleep_range() but that does not ensure optimal handling of > all the different values from device tree properties. > By switching to the new flexible sleeping helper function, > fsleep(), the correct delay function is called depending on > delay length, e.g. udelay(), usleep_range() or msleep(). > > Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
diff --git a/drivers/net/phy/mdio_device.c b/drivers/net/phy/mdio_device.c index 0f625a1b1644..0837319a52d7 100644 --- a/drivers/net/phy/mdio_device.c +++ b/drivers/net/phy/mdio_device.c @@ -132,7 +132,7 @@ void mdio_device_reset(struct mdio_device *mdiodev, int value) d = value ? mdiodev->reset_assert_delay : mdiodev->reset_deassert_delay; if (d) - usleep_range(d, d + max_t(unsigned int, d / 10, 100)); + fsleep(d); } EXPORT_SYMBOL(mdio_device_reset);
MDIO device reset assert and deassert length was created by usleep_range() but that does not ensure optimal handling of all the different values from device tree properties. By switching to the new flexible sleeping helper function, fsleep(), the correct delay function is called depending on delay length, e.g. udelay(), usleep_range() or msleep(). Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com> --- drivers/net/phy/mdio_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)