diff mbox series

[15/29] l2tp: comment per net spinlock instances

Message ID	20200721173221.4681-16-tparkin@katalix.com
State	Changes Requested
Delegated to:	David Miller
Headers	show Return-Path: <netdev-owner@vger.kernel.org> sender: tom) by mail.katalix.com (Postfix) with ESMTPSA id 60DF993AFF; Tue, 21 Jul 2020 18:33:01 +0100 (BST) From: Tom Parkin <tparkin@katalix.com> To: netdev@vger.kernel.org Cc: Tom Parkin <tparkin@katalix.com> Subject: [PATCH 15/29] l2tp: comment per net spinlock instances Date: Tue, 21 Jul 2020 18:32:07 +0100 Message-Id: <20200721173221.4681-16-tparkin@katalix.com> In-Reply-To: <20200721173221.4681-1-tparkin@katalix.com> References: <20200721173221.4681-1-tparkin@katalix.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk
Series	l2tp: cleanup checkpatch.pl warnings \| expand [net-next,00/29] l2tp: cleanup checkpatch.pl warnings [01/29] l2tp: cleanup whitespace around operators [02/29] l2tp: tweak comment style for consistency [03/29] l2tp: add a blank line following declarations [04/29] l2tp: cleanup excessive blank lines [05/29] l2tp: cleanup difficult-to-read line breaks [06/29] l2tp: cleanup wonky alignment of line-broken function calls [07/29] l2tp: cleanup suspect code indent [08/29] l2tp: add identifier name in function pointer prototype [09/29] l2tp: prefer using BIT macro [10/29] l2tp: cleanup comparisons to NULL [11/29] l2tp: cleanup unnecessary braces in if statements [12/29] l2tp: prefer seq_puts for unformatted output [13/29] l2tp: avoid multiple assignments [14/29] l2tp: line-break long function prototypes [15/29] l2tp: comment per net spinlock instances [16/29] l2tp: fix up incorrect comment in l2tp_recv_common [17/29] l2tp: avoid precidence issues in L2TP_SKB_CB macro [18/29] l2tp: WARN_ON rather than BUG_ON in l2tp_debugfs.c [19/29] l2tp: use a function to render tunnel address in l2tp_debugfs [20/29] l2tp: cleanup netlink send of tunnel address information [21/29] l2tp: cleanup netlink tunnel create address handling [22/29] l2tp: cleanup kzalloc calls [23/29] l2tp: remove BUG_ON in l2tp_session_queue_purge [24/29] l2tp: remove BUG_ON in l2tp_tunnel_closeall [25/29] l2tp: don't BUG_ON session magic checks in l2tp_ppp [26/29] l2tp: don't BUG_ON seqfile checks in l2tp_ppp [27/29] l2tp: WARN_ON rather than BUG_ON in l2tp_session_queue_purge [28/29] l2tp: remove BUG_ON refcount value in l2tp_session_free [29/29] l2tp: WARN_ON rather than BUG_ON in l2tp_session_free

Commit Message

Tom Parkin July 21, 2020, 5:32 p.m. UTC

checkpatch warns on spinlocks which are not commented as to their use.

Comment l2tp's per net locks accordingly.

Signed-off-by: Tom Parkin <tparkin@katalix.com>
---
 net/l2tp/l2tp_core.c | 2 ++
 1 file changed, 2 insertions(+)

diff mbox series

Patch

diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
index ef393604e66e..182386ad20e2 100644
--- a/net/l2tp/l2tp_core.c
+++ b/net/l2tp/l2tp_core.c
@@ -101,8 +101,10 @@  static struct workqueue_struct *l2tp_wq;
 static unsigned int l2tp_net_id;
 struct l2tp_net {
 	struct list_head l2tp_tunnel_list;
+	/* Lock for write access to l2tp_tunnel_list */
 	spinlock_t l2tp_tunnel_list_lock;
 	struct hlist_head l2tp_session_hlist[L2TP_HASH_SIZE_2];
+	/* Lock for write access to l2tp_session_hlist */
 	spinlock_t l2tp_session_hlist_lock;
 };