| Message ID | 20200715085427.8713-1-grygorii.strashko@ti.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
| Series | ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy | expand |
Hi Santosh, On 7/15/20 2:24 PM, Grygorii Strashko wrote: > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the > KSZ9031 PHY") the networking is broken on keystone-k2g-evm board. > > The above board have phy-mode = "rgmii-id" and it is worked before because > KSZ9031 PHY started with default RGMII internal delays configuration (TX > off, RX on 1.2 ns) and MAC provided TX delay by default. > After above commit, the KSZ9031 PHY starts handling phy mode properly and > enables both RX and TX delays, as result networking is become broken. > > Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous > behavior. > > Cc: Oleksij Rempel <o.rempel@pengutronix.de> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Philippe Schenker <philippe.schenker@toradex.com> > Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > --- > Fix for one more broken TI board with KSZ9031 PHY. This is coming bit late, but its important to get into v5.8 since NFS boot fails without this blocking all mainline testing for this platform. Can we send this to ARM SoC for -rc7. If you are going to be busy this week, I am happy to send a pull request on your behalf with your ack included. Let me know. Thanks, Sekhar
diff --git a/arch/arm/boot/dts/keystone-k2g-evm.dts b/arch/arm/boot/dts/keystone-k2g-evm.dts index db640bab8c1d..8b3d64c913d8 100644 --- a/arch/arm/boot/dts/keystone-k2g-evm.dts +++ b/arch/arm/boot/dts/keystone-k2g-evm.dts @@ -402,7 +402,7 @@ &gbe0 { phy-handle = <ðphy0>; - phy-mode = "rgmii-id"; + phy-mode = "rgmii-rxid"; status = "okay"; };
Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") the networking is broken on keystone-k2g-evm board. The above board have phy-mode = "rgmii-id" and it is worked before because KSZ9031 PHY started with default RGMII internal delays configuration (TX off, RX on 1.2 ns) and MAC provided TX delay by default. After above commit, the KSZ9031 PHY starts handling phy mode properly and enables both RX and TX delays, as result networking is become broken. Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous behavior. Cc: Oleksij Rempel <o.rempel@pengutronix.de> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Philippe Schenker <philippe.schenker@toradex.com> Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- Fix for one more broken TI board with KSZ9031 PHY. arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)