diff mbox series

gianfar: Use random MAC address when none is given

Message ID 20200714120104.257819-1-fido_max@inbox.ru
State Accepted
Delegated to: David Miller
Headers show
Series gianfar: Use random MAC address when none is given | expand

Commit Message

Maxim Kochetkov July 14, 2020, 12:01 p.m. UTC
If there is no valid MAC address in the device tree,
use a random MAC address.

Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
---
 drivers/net/ethernet/freescale/gianfar.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

David Miller July 14, 2020, 9:17 p.m. UTC | #1
From: Maxim Kochetkov <fido_max@inbox.ru>
Date: Tue, 14 Jul 2020 15:01:04 +0300

> If there is no valid MAC address in the device tree,
> use a random MAC address.
> 
> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>

Looks good, patch applied, thanks.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
index b3c69e9038ea..b513b8c5c3b5 100644
--- a/drivers/net/ethernet/freescale/gianfar.c
+++ b/drivers/net/ethernet/freescale/gianfar.c
@@ -779,8 +779,12 @@  static int gfar_of_init(struct platform_device *ofdev, struct net_device **pdev)
 
 	mac_addr = of_get_mac_address(np);
 
-	if (!IS_ERR(mac_addr))
+	if (!IS_ERR(mac_addr)) {
 		ether_addr_copy(dev->dev_addr, mac_addr);
+	} else {
+		eth_hw_addr_random(dev);
+		dev_info(&ofdev->dev, "Using random MAC address: %pM\n", dev->dev_addr);
+	}
 
 	if (model && !strcasecmp(model, "TSEC"))
 		priv->device_flags |= FSL_GIANFAR_DEV_HAS_GIGABIT |