| Message ID | 20200708154634.9565-1-frank-w@public-files.de |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: ethernet: mtk_eth_soc: fix mtu warning | expand |
On Wed, 8 Jul 2020 17:46:34 +0200 Frank Wunderlich wrote: > From: René van Dorst <opensource@vdorst.com> > > in recent Kernel-Versions there are warnings about incorrect MTU-Size > like these: > > mt7530 mdio-bus:00: nonfatal error -95 setting MTU on port x > eth0: mtu greater than device maximum > mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead > > Signed-off-by: René van Dorst <opensource@vdorst.com> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > > Fixes: bfcb813203 ("net: dsa: configure the MTU for switch ports") > Fixes: 72579e14a1 ("net: dsa: don't fail to probe if we couldn't set the MTU") > Fixes: 7a4c53bee3 ("net: report invalid mtu value via netlink extack") Fixes tag: Fixes: bfcb813203 ("net: dsa: configure the MTU for switch ports") Has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11 or later) just making sure it is not set (or set to "auto"). Fixes tag: Fixes: 72579e14a1 ("net: dsa: don't fail to probe if we couldn't set the MTU") Has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11 or later) just making sure it is not set (or set to "auto"). Fixes tag: Fixes: 7a4c53bee3 ("net: report invalid mtu value via netlink extack") Has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11 or later) just making sure it is not set (or set to "auto").
From: Frank Wunderlich <frank-w@public-files.de> Date: Wed, 8 Jul 2020 17:46:34 +0200 > From: René van Dorst <opensource@vdorst.com> > > in recent Kernel-Versions there are warnings about incorrect MTU-Size > like these: > > mt7530 mdio-bus:00: nonfatal error -95 setting MTU on port x > eth0: mtu greater than device maximum > mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead > > Signed-off-by: René van Dorst <opensource@vdorst.com> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > > Fixes: bfcb813203 ("net: dsa: configure the MTU for switch ports") > Fixes: 72579e14a1 ("net: dsa: don't fail to probe if we couldn't set the MTU") > Fixes: 7a4c53bee3 ("net: report invalid mtu value via netlink extack") In addition to the other Fixes: tag problems pointed out so far, you should always put the Fixes: tags first, and immediately before the other tags such as Signed-off-by: etc. and with no empty lines separating them. Thank you.
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 85735d32ecb0..00e3d70f7d07 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -2891,6 +2891,10 @@ static int mtk_add_mac(struct mtk_eth *eth, struct device_node *np) eth->netdev[id]->irq = eth->irq[0]; eth->netdev[id]->dev.of_node = np; + eth->netdev[id]->mtu = 1536; + eth->netdev[id]->min_mtu = ETH_MIN_MTU; + eth->netdev[id]->max_mtu = 1536; + return 0; free_netdev: