| Message ID | 20200708044513.91534-1-f.fainelli@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: dsa: loop: Print when registration is successful | expand |
On Tue, Jul 07, 2020 at 09:45:13PM -0700, Florian Fainelli wrote: > We have a number of error conditions that can lead to the driver not > probing successfully, move the print when we are sure > dsa_register_switch() has suceeded. This avoids repeated prints in case > of probe deferral for instance. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Tue, 7 Jul 2020 21:45:13 -0700, Florian Fainelli <f.fainelli@gmail.com> wrote: > We have a number of error conditions that can lead to the driver not > probing successfully, move the print when we are sure > dsa_register_switch() has suceeded. This avoids repeated prints in case > of probe deferral for instance. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com> Date: Tue, 7 Jul 2020 21:45:13 -0700 > We have a number of error conditions that can lead to the driver not > probing successfully, move the print when we are sure > dsa_register_switch() has suceeded. This avoids repeated prints in case > of probe deferral for instance. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Applied.
diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c index 400207c5c7de..f8bc85a6e670 100644 --- a/drivers/net/dsa/dsa_loop.c +++ b/drivers/net/dsa/dsa_loop.c @@ -280,13 +280,11 @@ static int dsa_loop_drv_probe(struct mdio_device *mdiodev) struct dsa_loop_pdata *pdata = mdiodev->dev.platform_data; struct dsa_loop_priv *ps; struct dsa_switch *ds; + int ret; if (!pdata) return -ENODEV; - dev_info(&mdiodev->dev, "%s: 0x%0x\n", - pdata->name, pdata->enabled_ports); - ds = devm_kzalloc(&mdiodev->dev, sizeof(*ds), GFP_KERNEL); if (!ds) return -ENOMEM; @@ -311,7 +309,12 @@ static int dsa_loop_drv_probe(struct mdio_device *mdiodev) dev_set_drvdata(&mdiodev->dev, ds); - return dsa_register_switch(ds); + ret = dsa_register_switch(ds); + if (!ret) + dev_info(&mdiodev->dev, "%s: 0x%0x\n", + pdata->name, pdata->enabled_ports); + + return ret; } static void dsa_loop_drv_remove(struct mdio_device *mdiodev)
We have a number of error conditions that can lead to the driver not probing successfully, move the print when we are sure dsa_register_switch() has suceeded. This avoids repeated prints in case of probe deferral for instance. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- drivers/net/dsa/dsa_loop.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)