From patchwork Mon Jul 6 13:52:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 1323635 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: incoming-bpf@patchwork.ozlabs.org Delivered-To: patchwork-incoming-bpf@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=bpf-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=huawei.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B0mvm2G1Hz9sQt for ; Mon, 6 Jul 2020 23:42:12 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728961AbgGFNmK (ORCPT ); Mon, 6 Jul 2020 09:42:10 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:47740 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729158AbgGFNmK (ORCPT ); Mon, 6 Jul 2020 09:42:10 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 13701B9CE76425DA7FFA; Mon, 6 Jul 2020 21:42:09 +0800 (CST) Received: from kernelci-master.huawei.com (10.175.101.6) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Mon, 6 Jul 2020 21:41:57 +0800 From: Wei Yongjun To: Hulk Robot , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexei Starovoitov , Daniel Borkmann CC: Wei Yongjun , , Subject: [PATCH -next] perf/core: Make some symbols static Date: Mon, 6 Jul 2020 21:52:08 +0800 Message-ID: <20200706135208.80692-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.175.101.6] X-CFilter-Loop: Reflected Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org sparse report build warning as follows: kernel/events/core.c:6493:6: warning: symbol 'perf_pmu_snapshot_aux' was not declared. Should it be static? kernel/events/core.c:10545:1: warning: symbol 'dev_attr_nr_addr_filters' was not declared. Should it be static? 'perf_pmu_snapshot_aux' and 'dev_attr_nr_addr_filters' are not used outside of this file, so mark them static. Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- kernel/events/core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 1449553a8d44..9465f30ad981 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -6490,10 +6490,10 @@ static unsigned long perf_prepare_sample_aux(struct perf_event *event, return data->aux_size; } -long perf_pmu_snapshot_aux(struct perf_buffer *rb, - struct perf_event *event, - struct perf_output_handle *handle, - unsigned long size) +static long perf_pmu_snapshot_aux(struct perf_buffer *rb, + struct perf_event *event, + struct perf_output_handle *handle, + unsigned long size) { unsigned long flags; long ret; @@ -10542,7 +10542,7 @@ static ssize_t nr_addr_filters_show(struct device *dev, return snprintf(page, PAGE_SIZE - 1, "%d\n", pmu->nr_addr_filters); } -DEVICE_ATTR_RO(nr_addr_filters); +static DEVICE_ATTR_RO(nr_addr_filters); static struct idr pmu_idr;