| Message ID | 20200630044313.26698-1-f.fainelli@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: dsa: Improve subordinate PHY error message | expand |
On Mon, Jun 29, 2020 at 09:43:13PM -0700, Florian Fainelli wrote: > It is not very informative to know the DSA master device when a > subordinate network device fails to get its PHY setup. Provide the > device name and capitalize PHY while we are it. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
From: Florian Fainelli <f.fainelli@gmail.com> Date: Mon, 29 Jun 2020 21:43:13 -0700 > It is not very informative to know the DSA master device when a > subordinate network device fails to get its PHY setup. Provide the > device name and capitalize PHY while we are it. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Applied, thanks.
diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 4c7f086a047b..e147e10b411c 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -1795,7 +1795,8 @@ int dsa_slave_create(struct dsa_port *port) ret = dsa_slave_phy_setup(slave_dev); if (ret) { - netdev_err(master, "error %d setting up slave phy\n", ret); + netdev_err(master, "error %d setting up slave PHY for %s\n", + ret, slave_dev->name); goto out_gcells; }
It is not very informative to know the DSA master device when a subordinate network device fails to get its PHY setup. Provide the device name and capitalize PHY while we are it. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- net/dsa/slave.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)