| Message ID | 20200625201215.57833-1-snelson@pensando.io |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] ionic: update the queue count on open | expand |
On Thu, 25 Jun 2020 13:12:15 -0700 Shannon Nelson wrote: > Let the network stack know the real number of queues that > we are using. > > Fixes: 49d3b493673a ("ionic: disable the queues on link down") > Signed-off-by: Shannon Nelson <snelson@pensando.io> > --- > drivers/net/ethernet/pensando/ionic/ionic_lif.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c > index aaa00edd9d5b..62858c7afae0 100644 > --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c > +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c > @@ -1673,6 +1673,9 @@ int ionic_open(struct net_device *netdev) > if (err) > goto err_out; > > + netif_set_real_num_tx_queues(netdev, lif->nxqs); > + netif_set_real_num_rx_queues(netdev, lif->nxqs); These calls can fail.
On 6/25/20 3:57 PM, Jakub Kicinski wrote: > On Thu, 25 Jun 2020 13:12:15 -0700 Shannon Nelson wrote: >> Let the network stack know the real number of queues that >> we are using. >> >> Fixes: 49d3b493673a ("ionic: disable the queues on link down") >> Signed-off-by: Shannon Nelson <snelson@pensando.io> >> --- >> drivers/net/ethernet/pensando/ionic/ionic_lif.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c >> index aaa00edd9d5b..62858c7afae0 100644 >> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c >> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c >> @@ -1673,6 +1673,9 @@ int ionic_open(struct net_device *netdev) >> if (err) >> goto err_out; >> >> + netif_set_real_num_tx_queues(netdev, lif->nxqs); >> + netif_set_real_num_rx_queues(netdev, lif->nxqs); > These calls can fail. Ah, yes they can. I'll update this. sln
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c index aaa00edd9d5b..62858c7afae0 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c @@ -1673,6 +1673,9 @@ int ionic_open(struct net_device *netdev) if (err) goto err_out; + netif_set_real_num_tx_queues(netdev, lif->nxqs); + netif_set_real_num_rx_queues(netdev, lif->nxqs); + /* don't start the queues until we have link */ if (netif_carrier_ok(netdev)) { err = ionic_start_queues(lif);
Let the network stack know the real number of queues that we are using. Fixes: 49d3b493673a ("ionic: disable the queues on link down") Signed-off-by: Shannon Nelson <snelson@pensando.io> --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 3 +++ 1 file changed, 3 insertions(+)