| Message ID | 20200605110413.GF978434@mwanda |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] ethtool: linkinfo: remove an unnecessary NULL check | expand |
On Fri, Jun 05, 2020 at 02:04:13PM +0300, Dan Carpenter wrote: > This code generates a Smatch warning: > > net/ethtool/linkinfo.c:143 ethnl_set_linkinfo() > warn: variable dereferenced before check 'info' (see line 119) > > Fortunately, the "info" pointer is never NULL so the check can be > removed. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Michal Kubecek <mkubecek@suse.cz> The same useless check is also in ethnl_set_linkmodes(), I'll send a patch for that one. Michal > --- > net/ethtool/linkinfo.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/ethtool/linkinfo.c b/net/ethtool/linkinfo.c > index 677068deb68c0..5eaf173eaaca5 100644 > --- a/net/ethtool/linkinfo.c > +++ b/net/ethtool/linkinfo.c > @@ -140,8 +140,7 @@ int ethnl_set_linkinfo(struct sk_buff *skb, struct genl_info *info) > > ret = __ethtool_get_link_ksettings(dev, &ksettings); > if (ret < 0) { > - if (info) > - GENL_SET_ERR_MSG(info, "failed to retrieve link settings"); > + GENL_SET_ERR_MSG(info, "failed to retrieve link settings"); > goto out_ops; > } > lsettings = &ksettings.base; > -- > 2.26.2 >
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Fri, 5 Jun 2020 14:04:13 +0300 > This code generates a Smatch warning: > > net/ethtool/linkinfo.c:143 ethnl_set_linkinfo() > warn: variable dereferenced before check 'info' (see line 119) > > Fortunately, the "info" pointer is never NULL so the check can be > removed. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied.
diff --git a/net/ethtool/linkinfo.c b/net/ethtool/linkinfo.c index 677068deb68c0..5eaf173eaaca5 100644 --- a/net/ethtool/linkinfo.c +++ b/net/ethtool/linkinfo.c @@ -140,8 +140,7 @@ int ethnl_set_linkinfo(struct sk_buff *skb, struct genl_info *info) ret = __ethtool_get_link_ksettings(dev, &ksettings); if (ret < 0) { - if (info) - GENL_SET_ERR_MSG(info, "failed to retrieve link settings"); + GENL_SET_ERR_MSG(info, "failed to retrieve link settings"); goto out_ops; } lsettings = &ksettings.base;
This code generates a Smatch warning: net/ethtool/linkinfo.c:143 ethnl_set_linkinfo() warn: variable dereferenced before check 'info' (see line 119) Fortunately, the "info" pointer is never NULL so the check can be removed. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- net/ethtool/linkinfo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)